Bug 3765

---- Reported by nengard@gmail.com 2009-11-04 20:10:19 ----

Created an attachment
patron add form

When you enter road types they appear before the address on the patron display  :

 Boulevard, 123 Main
Atlantic City 08401


Where Boulevard is the Road Type chosen from the authorized value list.  See attached



---- Additional Comments From nengard@gmail.com 2009-11-04 20:10:35 ----

Created an attachment
patron detail





---- Additional Comments From nengard@gmail.com 2009-12-28 22:41:03 ----

Created an attachment
patch





---- Additional Comments From nengard@gmail.com 2009-12-29 17:03:37 ----

There are still issues that this patch did not resolve.  Will be submitting another patch.



---- Additional Comments From nengard@gmail.com 2009-12-29 17:41:22 ----

Created an attachment
patch part 2

This patch fixed more of the same issues.  The only pages left to be fixed are:

members/readingrec.pl
members/messaging.pl
members/notices.pl

All of which gather the patron's info in a way that I'm unfamiliar with and so I can't seem to fix those.  I would love to see how to resolve those issues as well.



---- Additional Comments From nengard@gmail.com 2009-12-29 18:03:45 ----

Please ignore the patches - it looks likes this is a bigger internationalization issue.


CHAT:

[11:57]  <owen> I wonder if http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3765 is a Frenchism?
[11:57]  <munin> Bug http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3765 normal, PATCH-Sent, ---, nengard@gmail.com, NEW, Road Types on Patron Record Confusing
[11:58]  <nengard> putting the road type first?
[11:58]  <nengard> hmmm ... hope not - cause I patched it :) 
[11:58]  <owen> Right: "7 rue de Nesle"
[11:58]  <owen> number, street, street name
[11:58]  <nengard> good
[11:59]  <nengard> so it did need patching
[12:01]  <owen> Is it related to http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3349?
[12:01]  <munin> Bug http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3349 minor, PATCH-Sent, ---, jeanandre.santoni@biblibre.com, ASSIGNED, display of address truncated
[12:02]  <nengard> yes, but i patched that too
[12:02]  <nengard> on a diff bug - off to find that bug number so i can link the two together
[12:03]  <nengard> owen - i think i cleared it up and closed the right things
[12:03]  <nengard> let me know if you find others
[12:04]  <nengard> hmmm - not fixed ... wierd - okay i need to poke some more
[12:06]  <nengard> owen - do you know why each of the tabs on the left of the patron record has a different version of the patron address above it - shouldn't they all be the same include?
[12:09]  <owen> I think it's two includes: circ-menu.inc and member-menu.inc
[12:10]  <nengard> hmmm
[12:10]  <nengard> off to check them both out
[12:10]  <owen> We may have had two because not all pages provided the same data to all templates
[12:15]  <nengard> owen - i only see the two you mentioned, and yet all of my pages are displaying different info  -which i think means it's in the *.pl - so now i need to check them all
[12:15]  <nengard> bleh - 
[12:16]  * wizzyrea (~wizzyrea@198.248.80.135) has joined #koha
[12:16]  * wizzyrea (~wizzyrea@198.248.80.135) has left #koha
[12:18]  * wizzyrea (~wizzyrea@198.248.80.135) has joined #koha
[12:18]  * wizzyrea (~wizzyrea@198.248.80.135) has left #koha
[12:27]  * brendan has quit (Quit: brendan)
[12:29]  <nengard> all but 3 fixed
[12:34]  <nengard> anyone on who knows perl?
[12:34]  <nengard> I can solve all but 3 of the files cause these three do things diff from the others
[12:35]  <owen> I don't know perl, but I'm curious what you're looking at
[12:36]  <nengard> okay - so here are the files: members/notices.pl  is not showing the address right on the left side
[12:37]  <nengard> and members/moremember.pl is  -- but only after my file edits
[12:37]  <nengard> but in the two files you'll see how the patron info is pulled into the template differently - which is why i'm stuck
[12:40]  <nengard> owen - sent in a patch
[12:40]  <nengard> so you can see what i changed
[12:48]  <owen> nengard: That patch doesn't apply for me.
[12:48]  <nengard> oh geeze
[12:48]  <nengard> why the heck not!!!!
[12:50]  <owen> does it depend on the first patch you attached to http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3765?
[12:50]  <munin> Bug http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3765 normal, PATCH-Sent, ---, nengard@gmail.com, NEW, Road Types and Street Numbers on Patron Rec Inconsistent
[12:51]  <nengard> owen - probably - i changed the same files - some of the same files again
[12:52]  <owen> Those two applied fine in sequence.
[12:54]  <owen> nengard: I think this street number + road type issue is a red herring for American libraries. I think it's relevant only to French libraries.
[12:55]  <owen> If you move the road type display to the end of the address, you're mangling the construction from the point of view of the French users (I think)
[12:55]  <nengard> owen - yeah cause most us libraries don't use all three fields, but still it should work
[12:55]  <nengard> wait - i thought you said I did it right ....
[12:55]  <owen> In "7 rue de Nesle" "rue" is the road type.
[12:56]  <nengard> hmmmmm
[12:56]  <nengard> and grrrr
[12:56]  <nengard> cause i do know us libraries using the road type field
[12:56]  <nengard> as an authorized value
[12:56]  <nengard> so - now what the heck do we do?
[12:57]  <owen> And they just live with the fact that addresses display strangely?
[12:58]  <nengard> i guess ... but maybe a sys pref - i know it's an ugly word -but a pref to say what field goes where --
[13:00]  <owen> That's one of the problems with a construction like this being in the Perl code and not the template: my $address = $borrower->{'streetnumber'}.' '.$roadttype_hashref->{$borrower->{'streettype'}}.' '.$borrower->{'address'};
[13:01]  <owen> Now that string is hard-coded, and you can't rearrange it in the template based on TMPL_IFs
[13:01]  <nengard> so - you recommend us putting it in the template instead? cause that can be done
[13:01]  <nengard> I know how to edit the PL files to do that
[13:02]  <owen> At this point it would just be a best-practice thing. Without some kind of system for switching the layouts (like a sys pref) doing so wouldn't solve the problem.
[13:02]  <nengard> I'm going to update the bug report and ask for my patches to be ignored



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:14 UTC  ---

This bug was previously known as _bug_ 3765 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3765
Imported an attachment (id=1557)
Imported an attachment (id=1558)
Imported an attachment (id=1559)
Imported an attachment (id=1560)

Actual time not defined. Setting to 0.0
The original submitter of attachment 1557 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1558 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1559 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1560 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.