Bug 37651

Summary:	biblio->current_holds and item->current_holds do not respect ConfirmFutureHolds
Product:	Koha	Reporter:	Marcel de Rooy <m.de.rooy>
Component:	Hold requests	Assignee:	Marcel de Rooy <m.de.rooy>
Status:	Needs Signoff ---	QA Contact:	Testopia <testopia>
Severity:	enhancement
Priority:	P5 - low	CC:	gmcharlt
Version:	Main
Hardware:	All
OS:	All
See Also:	https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37650
Change sponsored?:	---	Patch complexity:	Small patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 37651: Add ConfirmFutureHolds to item->current_holds Bug 37651: Add ConfirmFutureHolds to biblio->current_holds Bug 37651: Unit tests Bug 37651: Unit tests

Description Marcel de Rooy 2024-08-15 13:50:28 UTC

See also bug 37650.
When we consider ConfirmFutureHolds to build the holds to pull list, we actually could say that these holds, probably only one or two days ahead, are current holds too. Currently, they are just completely ignored. But e.g. having a library depot further away require collecting those items earlier etc.

At least the majority of calls look like they could use the lookahead days from ConfirmFutureHolds.

Filed as enh, but very close to a bug.

Comment 1 Marcel de Rooy 2024-09-10 12:20:40 UTC

Created attachment 171247 [details] [review]
Bug 37651: Add ConfirmFutureHolds to item->current_holds

Test plan:
Add future item level hold for another branch.
Check in. Confirm and transfer.
Note that without this patch, there is no patron info for the column
On hold for on transferstoreceive.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 2 Marcel de Rooy 2024-09-10 12:20:43 UTC

Created attachment 171248 [details] [review]
Bug 37651: Add ConfirmFutureHolds to biblio->current_holds

Test plan:
Easy way is to run the unit tests in the next patch.
One call of biblio->current_holds is hidden in acqui/parcel.pl. The
table column "Item holds / Total holds" should now make a difference
for an order referring to an item having future holds.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Comment 3 Marcel de Rooy 2024-09-10 12:20:45 UTC Comment hidden (obsolete)

Created attachment 171249 [details] [review]
Bug 37651: Unit tests

Test plan:
Run t/db_dependent/Holds.t (Without previous patches, it would fail.)
Run t/db_dependent/Koha/Biblios.t

Comment 4 Marcel de Rooy 2024-09-10 12:21:18 UTC

Created attachment 171250 [details] [review]
Bug 37651: Unit tests

Test plan:
Run t/db_dependent/Holds.t (Without previous patches, it would fail.)
Run t/db_dependent/Koha/Biblios.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>