Summary: | API query operators list doesn't match documentation | ||
---|---|---|---|
Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
Component: | REST API | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
Status: | Pushed to oldstable --- | QA Contact: | Paul Derscheid <paul.derscheid> |
Severity: | minor | ||
Priority: | P5 - low | CC: | david, fridolin.somers, lucas, martin.renvoize, paul.derscheid, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This restores "-not_in" so that it is now listed as a valid operator for filtering API responses.
|
Version(s) released in: |
24.11.00,24.05.06,23.11.11
|
Circulation function: | |||
Bug Depends on: | 37018 | ||
Bug Blocks: | |||
Attachments: |
Bug 37687: Restore -not_in operator
Bug 37687: Restore -not_in operator Bug 37687: Restore -not_in operator |
Description
Matt Blenkinsop
2024-08-20 13:48:25 UTC
Created attachment 170497 [details] [review] Bug 37687: Restore -not_in operator Test plan: 1) Compare the API documentation on query parameters and note that'-not_in' is listed as a valid operator. 2) Look at the patch diff - you will see that previously '-not_in' was not included in the list and now is Created attachment 170537 [details] [review] Bug 37687: Restore -not_in operator Test plan: 1) Compare the API documentation on query parameters and note that'-not_in' is listed as a valid operator. 2) Look at the patch diff - you will see that previously '-not_in' was not included in the list and now is Signed-off-by: David Nind <david@davidnind.com> Testing notes: 1. API documentation (search page for -not_in): https://api.koha-community.org/Development.html#section/Filtering-responses Created attachment 170566 [details] [review] Bug 37687: Restore -not_in operator Test plan: 1) Compare the API documentation on query parameters and note that'-not_in' is listed as a valid operator. 2) Look at the patch diff - you will see that previously '-not_in' was not included in the list and now is Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Great! Works like a charm :) Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 Does this not need a unit test ? Pushed to 23.11.x for 23.11.11 |