Summary: | It should be possible to enable/disable each authentication method on the OPAC and staff client | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | System Administration | Assignee: | Bugs List <koha-bugs> |
Status: | In Discussion --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, gmcharlt, katrin.fischer, lucas, martin.renvoize, oliver.behnke, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40596 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | Added OpacEnableLocalLogin/StaffEnableLocalLogin to disable local logins |
Description
Nick Clemens (kidclamp)
2024-08-23 12:53:43 UTC
100% agreed with all of this Just to vote this up a notch! I'm particularly interested in OpacEnableLocalLogin since leaving local login enabled after having switched to OIDC-based SSO is just confusing our users. Thanks Looking into a patch for OpacEnableLocalLogin... Created attachment 185341 [details] [review] Added OpacEnableLocalLogin/StaffEnableLocalLogin to disable local logins Ok, as promised, here's a first patch. I omitted whitespace changes (indentations) to facilitate the patch discussion. Let me know if you want to go forward with this. Note: what's missing is the corresponding DB rev upgrade. Cheers (In reply to Nick Clemens (kidclamp) from comment #0) > It would be nice to instead have a switch for each: > [...] > OpacEnableShibLogin > OpacEnableLDAPLogin These two are effectively managed in koha-conf.xml [1], presumably since they need further config entries that sysprefs are probably not tailored for. Do you suggest to move those to the sysprefs anyway? Cheers [1] https://git.koha-community.org/Koha-community/Koha/src/commit/3ea3c2a27a9e7fad62a30486826f0a1ce3740ace/etc/koha-conf.xml#L105 (In reply to Nick Clemens (kidclamp) from comment #0) > It would be nice to instead have a switch for each: > [...] > OpacEnableCASLogin How would that differ from the existing "casAuthentication"? Thanks Thanks @tcohen for referencing bug 40596! That means CAS and Shibboleth are already in the process of being refactored - and rightfully so. May I ask the question if we could thus constrain this bug to controlling local login only, at least if LDAP is out of the question? This way we could expedite my patch which would be highly appreciated by our users ;) Cheers |