Bug 37745

Summary: Duplicate class attributes break dropdown items
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: ReportsAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Lucas Gass (lukeg) <lucas>
Severity: normal    
Priority: P5 - low CC: caroline.cyr-la-rose, jake.deery, lucas, oleonard
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on: 35402    
Bug Blocks:    
Attachments: Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items
Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items
Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items
Bug 37745: Fix change framework
Bug 37745: Remove more duplicated class attributes
Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items
Bug 37745: Fix change framework
Bug 37745: Remove more duplicated class attributes
Bug 37745: (follow-up) Remove "btn-default" from two controls.
Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items
Bug 37745: Fix change framework
Bug 37745: Remove more duplicated class attributes
Bug 37745: (follow-up) Remove "btn-default" from two controls.

Description Jonathan Druart 2024-08-27 10:53:28 UTC

    
Comment 1 Jonathan Druart 2024-08-27 10:59:27 UTC
Created attachment 170760 [details] [review]
Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items

There were 2 class attributes.

Test plan:
Create a new report and run it
Use the "Rows per page" dropdown to select another value
=> Without this patch nothing happens
=> With this patch applied the page is reloaded and the correct number
of rows is displayed
Comment 2 Jake Deery 2024-08-27 11:00:23 UTC
Thanks for verifying this and raising a bug, Jonathan.

Jake.
Comment 3 Owen Leonard 2024-08-27 11:07:19 UTC
*** Bug 37746 has been marked as a duplicate of this bug. ***
Comment 4 Roman Dolny 2024-08-27 13:53:35 UTC
Created attachment 170772 [details] [review]
Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items

There were 2 class attributes.

Test plan:
Create a new report and run it
Use the "Rows per page" dropdown to select another value
=> Without this patch nothing happens
=> With this patch applied the page is reloaded and the correct number
of rows is displayed

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 5 Lucas Gass (lukeg) 2024-08-27 16:36:41 UTC
Created attachment 170776 [details] [review]
Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items

There were 2 class attributes.

Test plan:
Create a new report and run it
Use the "Rows per page" dropdown to select another value
=> Without this patch nothing happens
=> With this patch applied the page is reloaded and the correct number
of rows is displayed

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 6 Jonathan Druart 2024-08-29 10:21:14 UTC
Created attachment 170858 [details] [review]
Bug 37745: Fix change framework

Same problem as the previous patch when we try to change the bib
framework while editing a bib record
Comment 7 Jonathan Druart 2024-08-29 10:21:39 UTC
Can we get a quick SO+QA on this second patch please?
Comment 8 Jonathan Druart 2024-08-29 10:42:19 UTC
Created attachment 170859 [details] [review]
Bug 37745: Remove more duplicated class attributes

Found using `egrep 'class=[^>]+class=' **/*.tt **/*.inc`
Comment 9 Jonathan Druart 2024-08-29 10:43:02 UTC
No test plan for this last patch as it touches a lot of code. But more eyes are needed here, and fast: it seems that this last patch is fixing a lot of bugs!
Comment 10 Owen Leonard 2024-08-29 11:35:19 UTC
Created attachment 170866 [details] [review]
Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items

There were 2 class attributes.

Test plan:
Create a new report and run it
Use the "Rows per page" dropdown to select another value
=> Without this patch nothing happens
=> With this patch applied the page is reloaded and the correct number
of rows is displayed

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 11 Owen Leonard 2024-08-29 11:35:21 UTC
Created attachment 170867 [details] [review]
Bug 37745: Fix change framework

Same problem as the previous patch when we try to change the bib
framework while editing a bib record

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 12 Owen Leonard 2024-08-29 11:35:23 UTC
Created attachment 170868 [details] [review]
Bug 37745: Remove more duplicated class attributes

Found using `egrep 'class=[^>]+class=' **/*.tt **/*.inc`

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 13 Owen Leonard 2024-08-29 11:35:25 UTC
Created attachment 170869 [details] [review]
Bug 37745: (follow-up) Remove "btn-default" from two controls.

If we use "btn-link" we don't need "btn-default".
Comment 14 Jonathan Druart 2024-09-02 12:22:42 UTC
Please push this, it will fix a lot of bugs.
Comment 15 Katrin Fischer 2024-09-02 13:56:59 UTC
Can you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items
Applying: Bug 37745: Fix change framework
Applying: Bug 37745: Remove more duplicated class attributes
error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt).
error: could not build fake ancestor
Comment 16 Jonathan Druart 2024-09-02 14:05:38 UTC
Created attachment 170943 [details] [review]
Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items

There were 2 class attributes.

Test plan:
Create a new report and run it
Use the "Rows per page" dropdown to select another value
=> Without this patch nothing happens
=> With this patch applied the page is reloaded and the correct number
of rows is displayed

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 17 Jonathan Druart 2024-09-02 14:05:41 UTC
Created attachment 170944 [details] [review]
Bug 37745: Fix change framework

Same problem as the previous patch when we try to change the bib
framework while editing a bib record

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 18 Jonathan Druart 2024-09-02 14:05:44 UTC
Created attachment 170945 [details] [review]
Bug 37745: Remove more duplicated class attributes

Found using `egrep 'class=[^>]+class=' **/*.tt **/*.inc`

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 19 Jonathan Druart 2024-09-02 14:05:47 UTC
Created attachment 170946 [details] [review]
Bug 37745: (follow-up) Remove "btn-default" from two controls.

If we use "btn-link" we don't need "btn-default".
Comment 20 Katrin Fischer 2024-09-02 14:37:08 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 21 Phil Ringnalda 2024-09-05 21:31:00 UTC
*** Bug 37778 has been marked as a duplicate of this bug. ***