Description
Jonathan Druart
2024-08-27 10:53:28 UTC
Created attachment 170760 [details] [review] Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items There were 2 class attributes. Test plan: Create a new report and run it Use the "Rows per page" dropdown to select another value => Without this patch nothing happens => With this patch applied the page is reloaded and the correct number of rows is displayed Thanks for verifying this and raising a bug, Jonathan. Jake. *** Bug 37746 has been marked as a duplicate of this bug. *** Created attachment 170772 [details] [review] Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items There were 2 class attributes. Test plan: Create a new report and run it Use the "Rows per page" dropdown to select another value => Without this patch nothing happens => With this patch applied the page is reloaded and the correct number of rows is displayed Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 170776 [details] [review] Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items There were 2 class attributes. Test plan: Create a new report and run it Use the "Rows per page" dropdown to select another value => Without this patch nothing happens => With this patch applied the page is reloaded and the correct number of rows is displayed Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 170858 [details] [review] Bug 37745: Fix change framework Same problem as the previous patch when we try to change the bib framework while editing a bib record Can we get a quick SO+QA on this second patch please? Created attachment 170859 [details] [review] Bug 37745: Remove more duplicated class attributes Found using `egrep 'class=[^>]+class=' **/*.tt **/*.inc` No test plan for this last patch as it touches a lot of code. But more eyes are needed here, and fast: it seems that this last patch is fixing a lot of bugs! Created attachment 170866 [details] [review] Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items There were 2 class attributes. Test plan: Create a new report and run it Use the "Rows per page" dropdown to select another value => Without this patch nothing happens => With this patch applied the page is reloaded and the correct number of rows is displayed Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 170867 [details] [review] Bug 37745: Fix change framework Same problem as the previous patch when we try to change the bib framework while editing a bib record Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 170868 [details] [review] Bug 37745: Remove more duplicated class attributes Found using `egrep 'class=[^>]+class=' **/*.tt **/*.inc` Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 170869 [details] [review] Bug 37745: (follow-up) Remove "btn-default" from two controls. If we use "btn-link" we don't need "btn-default". Please push this, it will fix a lot of bugs. Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items Applying: Bug 37745: Fix change framework Applying: Bug 37745: Remove more duplicated class attributes error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt). error: could not build fake ancestor Created attachment 170943 [details] [review] Bug 37745: (bug 35402 follow-up) Fix "Rows per page" dropdown items There were 2 class attributes. Test plan: Create a new report and run it Use the "Rows per page" dropdown to select another value => Without this patch nothing happens => With this patch applied the page is reloaded and the correct number of rows is displayed Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 170944 [details] [review] Bug 37745: Fix change framework Same problem as the previous patch when we try to change the bib framework while editing a bib record Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 170945 [details] [review] Bug 37745: Remove more duplicated class attributes Found using `egrep 'class=[^>]+class=' **/*.tt **/*.inc` Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 170946 [details] [review] Bug 37745: (follow-up) Remove "btn-default" from two controls. If we use "btn-link" we don't need "btn-default". Pushed for 24.11! Well done everyone, thank you! *** Bug 37778 has been marked as a duplicate of this bug. *** |