Bug 37796

Summary: Generated issue has incorrect number in pattern when receiving
Product: Koha Reporter: Esther Melander <esther.melander>
Component: SerialsAssignee: Nick Clemens (kidclamp) <nick>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: phil
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Incorrect number on generated issue
Bug 37796: Pass correct publication date when generating the next serial form the serial collection page
Bug 37796: Adjust unit tests
Bug 37796: Adjust GetNextSeq unit test file

Description Esther Melander 2024-08-30 20:32:40 UTC 
Created attachment 170927 [details]
Incorrect number on generated issue

Discovered while testing Bug 35646

To Replicate

1. Follow Bug 35646 and create a numbering pattern for {MonthName} {Year}.
2. Test the pattern for a 1/month frequency, subscription start date on the first day of the month.

See that the numbering pattern increments correctly for the month names and year.

3. Find a serial in the catalog and add a new subscription.
4. On the second page of the subscription configuration, select the numbering pattern for MonthName Year.
5. Test the prediction pattern and see everything increments correctly.
6. Save the subscription.
7. Receive.

See the the first issue displays correctly for the month name and year.

8. Mark the issue as arrived and generate the next issue.

See the next issue does not have the correct month name and year. (image attached).

9. Mark the next issue Arrived and generate the third issue.

The date published and number continue to increment incorrectly.

Possibly connected to bug 20653, though this example is not irregular.
Comment 1 Nick Clemens (kidclamp) 2024-09-13 20:09:23 UTC 
Created attachment 171498 [details] [review]
Bug 37796: Pass correct publication date when generating the next serial form the serial collection page

This patch changes the call to GetNextSeq from serial-collection.pl to ensure the new issue publication date is used to
generate the numbers

To test:
1 - On the serial used in previous patch go to 'Serial collection'
2 - Generate next issue
3 - Confirm the numbering is correctly generated after this patch
Comment 2 Nick Clemens (kidclamp) 2024-09-13 20:09:25 UTC 
Created attachment 171499 [details] [review]
Bug 37796: Adjust unit tests
Comment 3 Nick Clemens (kidclamp) 2024-09-13 20:09:27 UTC 
Created attachment 171500 [details] [review]
Bug 37796: Adjust GetNextSeq unit test file

The crux of the change here was adding an extra param to the call, but when it died
I had no idea where it did. Taking the liberty to tidy, move to subtests, and add diag