Summary: | Generated issue has incorrect number in pattern when receiving | ||
---|---|---|---|
Product: | Koha | Reporter: | Esther Melander <esther.melander> |
Component: | Serials | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | andrew, esther.melander, lisette, megan.mcshane, phil, yach |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Incorrect number on generated issue
Bug 37796: Pass correct publication date when generating the next serial form the serial collection page Bug 37796: Adjust unit tests Bug 37796: Adjust GetNextSeq unit test file Serial numbering pattern when receiving Bug 37796: Pass correct publication date when generating the next serial form the serial collection page |
Description
Esther Melander
2024-08-30 20:32:40 UTC
Created attachment 171498 [details] [review] Bug 37796: Pass correct publication date when generating the next serial form the serial collection page This patch changes the call to GetNextSeq from serial-collection.pl to ensure the new issue publication date is used to generate the numbers To test: 1 - On the serial used in previous patch go to 'Serial collection' 2 - Generate next issue 3 - Confirm the numbering is correctly generated after this patch Created attachment 171499 [details] [review] Bug 37796: Adjust unit tests Created attachment 171500 [details] [review] Bug 37796: Adjust GetNextSeq unit test file The crux of the change here was adding an extra param to the call, but when it died I had no idea where it did. Taking the liberty to tidy, move to subtests, and add diag Created attachment 177654 [details]
Serial numbering pattern when receiving
I tested this and the numbering pattern still seems to be off. When the prediction pattern is tested in the subscription it appears to be correct, but when receiving it is still one month off. I also tested this with a daily subscriptions and the generated issues were one day off. Attached screen shot of the generated issues for the month/year subscription.
We would appreciate any updates on this as well. I had the same issue as Esther. Created attachment 185723 [details] [review] Bug 37796: Pass correct publication date when generating the next serial form the serial collection page Before this patch, we pass the previous issue date to generate the next seq - this works for the pattern as we are incrementing. When the patter is translated ot words, we need to do this from the date of the next issue, so we must pass in the next published date This patch changes the call to GetNextSeq from serial-collection.pl to ensure the new issue publication date is used to generate the numbers. To test: 0 - Follow the plan to recreate from the initial bug description and recreate 1 - Apply patch 2 - On the serial used in previous patch go to 'Serial collection' 3 - Generate next issue 4 - Confirm the numbering is correctly generated after this patch Without this patch, the predicted pattern before saving the serial shows the correct month and year values for all expected issues. But after saving the subscription and receiving an issue, the pattern fails to progress correctly. With this patch, the predicted pattern before saving is incorrect, showing the current month and year for all predicted values. However, after saving the subscription and receiving an issue, the pattern DOES progress correctly. |