Summary: | Embed geographic coordinates when indexing biblios linked to GEOGR_NAME authorities | ||
---|---|---|---|
Product: | Koha | Reporter: | HKS3 Tadeusz Sośnierz <tadeusz> |
Component: | Searching - Elasticsearch | Assignee: | HKS3 Tadeusz Sośnierz <tadeusz> |
Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | phil, roman.dolny |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 37821: Embed geographic coordinates from GEOGR_NAME authority when indexing records
Bug 37821: Embed geographic coordinates from GEOGR_NAME authority when indexing records Bug 37821: POD and tidying Bug 37821: Embed geographic coordinates from GEOGR_NAME authority when indexing records Bug 37821: POD and tidying |
Description
HKS3 Tadeusz Sośnierz
2024-09-03 11:46:25 UTC
Created attachment 170979 [details] [review] Bug 37821: Embed geographic coordinates from GEOGR_NAME authority when indexing records Test plan: ## Preparation 1. Set up koha-testing-docker with --es8 2. Go to "The beginnings of Rome" in staff view (http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=140) 3. Go to the linked authority record ("Rome -- History -- Kings, 753-510 B.C") by clicking the looking glass. Should end up at http://localhost:8081/cgi-bin/koha/authorities/detail.pl?authid=169 4. Click "edit record" 5. Add field 034 ("CODED CARTOGRAPHIC MATHEMATICAL DATA") 6. For subfieds `s` and `t` enter the coordinates for Rome: 41.89193 and 12.51133 7. Save the authority record ## Testing 8. In koha-shell, issue the elasticsearch query: ``` curl -X GET "es:9200/koha_kohadev_biblios/_search?pretty" -H 'Content-Type: application/json' -d' { "query": { "bool": { "must": { "match_all": {} }, "filter": { "geo_distance": { "distance": "100km", "geolocation": { "lat": 41.89, "lon": 12.51 } } } } } } ' ``` Note no results. 9. Apply the patch 10. Rebuild the index with `koha-elasticsearch --rebuild kohadev` 11. Re-run the elasticsearch query 12. Notice the expected book pop up Works as described, but qa script unhappy: FAIL Koha/SearchEngine/Elasticsearch.pm FAIL pod coverage POD is missing for 'embed_geographic_name' FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/SearchEngine/Elasticsearch.pm` Created attachment 183156 [details] [review] Bug 37821: Embed geographic coordinates from GEOGR_NAME authority when indexing records Created attachment 183157 [details] [review] Bug 37821: POD and tidying Created attachment 183218 [details] [review] Bug 37821: Embed geographic coordinates from GEOGR_NAME authority when indexing records Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 183219 [details] [review] Bug 37821: POD and tidying Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> |