Summary: | Remove unreachable code in aqcontract.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Emily Lamancusa (emlam) <emily.lamancusa> |
Component: | Architecture, internals, and plumbing | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
Status: | Needs documenting --- | QA Contact: | Julian Maurice <julian.maurice> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, julian.maurice, lucas, phil |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37785 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 37728 | ||
Attachments: |
Bug 37823: Remove unreachable code in vendor contract page
Bug 37823: Remove unreachable code in vendor contract page Bug 37823: Remove unreachable code in vendor contract page |
Description
Emily Lamancusa (emlam)
2024-09-03 14:54:50 UTC
Created attachment 170990 [details] [review] Bug 37823: Remove unreachable code in vendor contract page The vendor contract management page has a few sections of code that are meant to display a minimal confirmation message ("Data recorded") after saving a new or edited vendor contract. However, aqcontract.pl redirects back to the vendor details page after saving, so this code is never reached and should be removed. Test plan: 1. Apply patch 2. Go to the Acquisitions module and find a vendor 3. Click + New > Contract 4. Fill in the information and click Save 5. Click the "Contracts" link in the navigation menu on the left --> Confirm that the contract was saved correctly 6. Click the Edit button and make changes to all fields 7. Save the information and click "Contracts" again --> Confirm that the new information saved correctly Testing note: I found an unrelated bug that the input validation isn't working correctly if the start date and/or end date is missing. This bug is present with and without my patch - I filed bug 37825 for it. Created attachment 171007 [details] [review] Bug 37823: Remove unreachable code in vendor contract page The vendor contract management page has a few sections of code that are meant to display a minimal confirmation message ("Data recorded") after saving a new or edited vendor contract. However, aqcontract.pl redirects back to the vendor details page after saving, so this code is never reached and should be removed. Test plan: 1. Apply patch 2. Go to the Acquisitions module and find a vendor 3. Click + New > Contract 4. Fill in the information and click Save 5. Click the "Contracts" link in the navigation menu on the left --> Confirm that the contract was saved correctly 6. Click the Edit button and make changes to all fields 7. Save the information and click "Contracts" again --> Confirm that the new information saved correctly Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Did you mean to handle the other one in the [% IF ( delete_confirmed ) %] block in this bug, too? Wups, meant to ask that as a question, not to take away my signoff. Created attachment 171128 [details] [review] Bug 37823: Remove unreachable code in vendor contract page The vendor contract management page has a few sections of code that are meant to display a minimal confirmation message ("Data recorded") after saving a new or edited vendor contract. However, aqcontract.pl redirects back to the vendor details page after saving, so this code is never reached and should be removed. Test plan: 1. Apply patch 2. Go to the Acquisitions module and find a vendor 3. Click + New > Contract 4. Fill in the information and click Save 5. Click the "Contracts" link in the navigation menu on the left --> Confirm that the contract was saved correctly 6. Click the Edit button and make changes to all fields 7. Save the information and click "Contracts" again --> Confirm that the new information saved correctly Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> It's always nice to see useless code removed, thanks Emily Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 I prefer not impact 23.11.x for stability :) |