Summary: | Wrong status in the Intranet detail page when the item type is not for loan | ||
---|---|---|---|
Product: | Koha | Reporter: | Adolfo Rodríguez Taboada <adolfo.rodriguez> |
Component: | Cataloging | Assignee: | Adolfo Rodríguez Taboada <adolfo.rodriguez> |
Status: | RESOLVED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, fridolin.somers, lucas, m.de.rooy, martin.renvoize, phil |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the status shown for items on record details pages in the staff interface. When an item type was set as not for loan, the status for individual items was incorrectly shown as "Available", instead of "Not for loan" (it was correctly shown as "Not for loan" in the OPAC).
(This is related to the changes made in Koha 24.05 to use the API to display holdings information in the staff interface, and improve the performance for records with many items.)
|
|
Version(s) released in: |
24.11.00,24.05.06
|
Circulation function: | |
Bug Depends on: | 33568 | ||
Bug Blocks: | |||
Attachments: |
bug 37840 Fix item status in the Intranet detail page when the item has a item type not for loan
Bug 37840: Fix item status in the Intranet detail page when the item has a item type not for loan Bug 37840: Fix item status in the Intranet detail page when the item has a item type not for loan |
Description
Adolfo Rodríguez Taboada
2024-09-05 07:15:25 UTC
Created attachment 171047 [details] [review] bug 37840 Fix item status in the Intranet detail page when the item has a item type not for loan When the item type is not for loan, the item status must be "Not for loan". Now in the Intranet status is Available while in the OPAC it's Not for loan. Test plan: 1 Define an item type as "Not for loan" 2 Add or edit an item so that its item type is "Not for loan" 3 Check that the status in the Intranet detail page shows Available while the OPAC detail page shows "Not for loan" 4 Apply patch, restart services 5 Check that the status is now "Not for loan" in both Intranet and OPAC The error is in the way it obtains the value of not for loan for the item type. item_types_notforloan[row.item_type_id] returns undefined always item_types_notforloan.get(row.item_type_id) returns 1 or 0 Created attachment 171106 [details] [review] Bug 37840: Fix item status in the Intranet detail page when the item has a item type not for loan When the item type is not for loan, the item status must be "Not for loan". Now in the Intranet status is Available while in the OPAC it's Not for loan. Test plan: 1 Define an item type as "Not for loan" 2 Add or edit an item so that its item type is "Not for loan" 3 Check that the status in the Intranet detail page shows Available while the OPAC detail page shows "Not for loan" 4 Apply patch, restart services 5 Check that the status is now "Not for loan" in both Intranet and OPAC Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Created attachment 171570 [details] [review] Bug 37840: Fix item status in the Intranet detail page when the item has a item type not for loan When the item type is not for loan, the item status must be "Not for loan". Now in the Intranet status is Available while in the OPAC it's Not for loan. Test plan: 1 Define an item type as "Not for loan" 2 Add or edit an item so that its item type is "Not for loan" 3 Check that the status in the Intranet detail page shows Available while the OPAC detail page shows "Not for loan" 4 Apply patch, restart services 5 Check that the status is now "Not for loan" in both Intranet and OPAC Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Backported to 24.05.x for upcoming 24.05.06 This is a bug fix, and no updates are required to the manual. |