Summary: | Serial prediction pattern test appears at the bottom of the page | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, jonathan.druart, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the test prediction pattern when adding a new subscription for a serial - the prediction pattern was appearing at the bottom of the page, instead of in a column to the right. (This is related to the OPAC and staff interface Bootstrap 5 upgrade in Koha 24.11.)
|
Version(s) released in: |
24.11.00
|
Circulation function: | |||
Bug Depends on: | 35402 | ||
Bug Blocks: | |||
Attachments: |
Bug 37846: Fix serial prediction pattern layout
Bug 37846: Fix serial prediction pattern layout Bug 37846: Fix serial prediction pattern layout |
Description
Caroline Cyr La Rose
2024-09-05 16:19:03 UTC
Created attachment 171134 [details] [review] Bug 37846: Fix serial prediction pattern layout This patch corrects the class which is added to the serial prediction pattern in order for it to display as a second column in the subscription edit page. "col-xs-*" classes no longer exist in Bootstrap 5. To test, apply the patch and go to Serials. 1. Click "New subscription" 2. Enter a record number in the form (e.g. 55) 3. Click "Next" (and confirm there is no vendor) 4. Enter values for - First issue publication date - Frequency - Subscription length - Subscription start date - Numbering pattern - Numbering "Begins with" 5. Click "Test prediction pattern" - The prediction pattern panel should appear as a second column on the page. Created attachment 171166 [details] [review] Bug 37846: Fix serial prediction pattern layout This patch corrects the class which is added to the serial prediction pattern in order for it to display as a second column in the subscription edit page. "col-xs-*" classes no longer exist in Bootstrap 5. To test, apply the patch and go to Serials. 1. Click "New subscription" 2. Enter a record number in the form (e.g. 55) 3. Click "Next" (and confirm there is no vendor) 4. Enter values for - First issue publication date - Frequency - Subscription length - Subscription start date - Numbering pattern - Numbering "Begins with" 5. Click "Test prediction pattern" - The prediction pattern panel should appear as a second column on the page. Signed-off-by: David Nind <david@davidnind.com> This code seems very fragile! Created attachment 171177 [details] [review] Bug 37846: Fix serial prediction pattern layout This patch corrects the class which is added to the serial prediction pattern in order for it to display as a second column in the subscription edit page. "col-xs-*" classes no longer exist in Bootstrap 5. To test, apply the patch and go to Serials. 1. Click "New subscription" 2. Enter a record number in the form (e.g. 55) 3. Click "Next" (and confirm there is no vendor) 4. Enter values for - First issue publication date - Frequency - Subscription length - Subscription start date - Numbering pattern - Numbering "Begins with" 5. Click "Test prediction pattern" - The prediction pattern panel should appear as a second column on the page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.11! Well done everyone, thank you! |