| Summary: | branchillemail missing from public libraries REST endpoint | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
| Component: | REST API | Assignee: | Pedro Amorim <pedro.amorim> |
| Status: | RESOLVED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | kyle, lucas, martin.renvoize, maryse.simard, pedro.amorim, phil, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This enhancement adds the library's e-mail address for interlibrary loans to the following public REST API endpoint's response:
<opac_url>/api/v1/public/libraries
|
Version(s) released in: |
24.11.00
|
| Circulation function: | |||
| Attachments: |
Bug 37850: Add branchillemail to libraries public REST endpoint
Bug 37850: Add branchillemail to libraries public REST endpoint Bug 37850: Add branchillemail to libraries public REST endpoint Bug 37850: (QA follow-up): Update illemail REST API attribute name |
||
|
Description
Pedro Amorim
2024-09-05 18:46:53 UTC
Created attachment 171102 [details] [review] Bug 37850: Add branchillemail to libraries public REST endpoint To test, before applying patch: 1) Visit <opac_url>/api/v1/public/libraries 2) Notice illemail is not shown for each library 3) Apply patch. Restart plack 4) Repeat 1). Notice illemail is now shown for each library Created attachment 172000 [details] [review] Bug 37850: Add branchillemail to libraries public REST endpoint To test, before applying patch: 1) Visit <opac_url>/api/v1/public/libraries 2) Notice illemail is not shown for each library 3) Apply patch. Restart plack 4) Repeat 1). Notice illemail is now shown for each library Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Created attachment 172003 [details] [review] Bug 37850: Add branchillemail to libraries public REST endpoint To test, before applying patch: 1) Visit <opac_url>/api/v1/public/libraries 2) Notice illemail is not shown for each library 3) Apply patch. Restart plack 4) Repeat 1). Notice illemail is now shown for each library Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! I am not a big fan of illemail as the name for the API, but this predates the patch. I think ill_email at least would have been a bit more consistent and easier to read. But too late. ;) Created attachment 173042 [details] [review] Bug 37850: (QA follow-up): Update illemail REST API attribute name To test 1) yarn api:bundle && koha-plack --restart kohadev 2) Enable ILLModule and put some 'ILL staff email:' on some library 3) Access <staff_url>/api/v1/libraries 4) Notice the attribute reads ill_email (In reply to Katrin Fischer from comment #5) > I am not a big fan of illemail as the name for the API, but this predates > the patch. I think ill_email at least would have been a bit more consistent > and easier to read. But too late. ;) I agree. Patch is added if you decide to push. (In reply to Pedro Amorim from comment #7) > (In reply to Katrin Fischer from comment #5) > > I am not a big fan of illemail as the name for the API, but this predates > > the patch. I think ill_email at least would have been a bit more consistent > > and easier to read. But too late. ;) > > I agree. Patch is added if you decide to push. Do you think it's save to push/not used much yet? Thinking of compatibility. (In reply to Katrin Fischer from comment #8) > (In reply to Pedro Amorim from comment #7) > > (In reply to Katrin Fischer from comment #5) > > > I am not a big fan of illemail as the name for the API, but this predates > > > the patch. I think ill_email at least would have been a bit more consistent > > > and easier to read. But too late. ;) > > > > I agree. Patch is added if you decide to push. > > Do you think it's save to push/not used much yet? Thinking of compatibility. Given that this was pushed to main 2 hours ago, I'd be very surprised if anyone is using this (we are, but we're aware of this last moment change). (In reply to Pedro Amorim from comment #9) > (In reply to Katrin Fischer from comment #8) > > (In reply to Pedro Amorim from comment #7) > > > (In reply to Katrin Fischer from comment #5) > > > > I am not a big fan of illemail as the name for the API, but this predates > > > > the patch. I think ill_email at least would have been a bit more consistent > > > > and easier to read. But too late. ;) > > > > > > I agree. Patch is added if you decide to push. > > > > Do you think it's save to push/not used much yet? Thinking of compatibility. > > Given that this was pushed to main 2 hours ago, I'd be very surprised if > anyone is using this (we are, but we're aware of this last moment change). I was thinking of the non-public route for libraries. Please push the follow-up.. we've gone from a 2 hour turn around on a patch to a 3 week delay!.. whilst there was zero chance of code being in production at time of writing, there's not a still low but not zero chance given the code has now been published for weeks not hours. Still not released however so should certainly not be held up any longer. (In reply to Martin Renvoize (ashimema) from comment #11) > Please push the follow-up.. we've gone from a 2 hour turn around on a patch > to a 3 week delay!.. whilst there was zero chance of code being in > production at time of writing, there's not a still low but not zero chance > given the code has now been published for weeks not hours. Still not > released however so should certainly not be held up any longer. ill_email on the non-public route is already released, so there is a change we are using it. I am not sure if it's used internally or not, I can try and test. I didn't spot any occurences. Picked follow-up for main. Pushed for 24.11! Well done everyone, thank you! Enhancement, no 24.05.x backport. |