Summary: | Returning to your account at the end of changing your password in the OPAC doesn't need to POST a form | ||
---|---|---|---|
Product: | Koha | Reporter: | Phil Ringnalda <phil> |
Component: | OPAC | Assignee: | Phil Ringnalda <phil> |
Status: | RESOLVED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P3 | CC: | fridolin.somers, lucas, ovezina |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00,24.05.06
|
Circulation function: | |
Bug Depends on: | 36192 | ||
Bug Blocks: | 37728 | ||
Attachments: |
Bug 37853: Returning to your account at the end of changing your password in the OPAC doesn't need to POST a form
Bug 37853: Returning to your account at the end of changing your password in the OPAC doesn't need to POST a form Bug 37853: Do not POST a form at the end of changing the password (OPAC) |
Description
Phil Ringnalda
2024-09-05 22:12:43 UTC
Created attachment 171107 [details] [review] Bug 37853: Returning to your account at the end of changing your password in the OPAC doesn't need to POST a form Rather than having a form that does a POST (without an op, which isn't proper), the final step in changing your password in the OPAC should just be a link. Test plan: 1. Without the patch applied, log in to the OPAC as a user that you don't mind changing the password for 2. Welcome, {username} - Your account - Change password 3. Type the old password, and a new password twice, click Change password 4. Below the success message is a green button with white text, Return to my account - click it 5. Apply patch 6. Change password, type the (new) old password, and a (newer) new password twice, click Change password 7. Below the success message is what looks like a green button with white text, Return to my account 8. Hover the button, check your browser status bar for a URL showing you that it's now a link. Click it to be sure it works. Sponsored-by: Chetco Community Public Library Created attachment 171193 [details] [review] Bug 37853: Returning to your account at the end of changing your password in the OPAC doesn't need to POST a form Rather than having a form that does a POST (without an op, which isn't proper), the final step in changing your password in the OPAC should just be a link. Test plan: 1. Without the patch applied, log in to the OPAC as a user that you don't mind changing the password for 2. Welcome, {username} - Your account - Change password 3. Type the old password, and a new password twice, click Change password 4. Below the success message is a green button with white text, Return to my account - click it 5. Apply patch 6. Change password, type the (new) old password, and a (newer) new password twice, click Change password 7. Below the success message is what looks like a green button with white text, Return to my account 8. Hover the button, check your browser status bar for a URL showing you that it's now a link. Click it to be sure it works. Sponsored-by: Chetco Community Public Library Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Created attachment 171311 [details] [review] Bug 37853: Do not POST a form at the end of changing the password (OPAC) Rather than having a form that does a POST (without an op, which isn't proper), the final step in changing your password in the OPAC should just be a link. Test plan: 1. Without the patch applied, log in to the OPAC as a user that you don't mind changing the password for 2. Welcome, {username} - Your account - Change password 3. Type the old password, and a new password twice, click Change password 4. Below the success message is a green button with white text, Return to my account - click it 5. Apply patch 6. Change password, type the (new) old password, and a (newer) new password twice, click Change password 7. Below the success message is what looks like a green button with white text, Return to my account 8. Hover the button, check your browser status bar for a URL showing you that it's now a link. Click it to be sure it works. Sponsored-by: Chetco Community Public Library Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Amended-by: Jonathan Druart Edited commit message Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 Not for 23.11.x Nothing to document, the button looks identical and the only change is that it's a GET rather than a POST. |