| Summary: | Barcode fails when adding item during order receive (again) | ||
|---|---|---|---|
| Product: | Koha | Reporter: | David Cook <dcook> |
| Component: | Acquisitions | Assignee: | David Cook <dcook> |
| Status: | Pushed to main --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | ovezina |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 8179, 28103, 29689 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 37854: Add fieldset.rows so that Javascript works
Bug 37854: Re-indent HTML (whitespace-only) Bug 37854: Add fieldset.rows so that Javascript works Bug 37854: Re-indent HTML (whitespace-only) Bug 37854: Add fieldset.rows so that Javascript works Bug 37854: Re-indent HTML (whitespace-only) |
||
|
Description
David Cook
2024-09-06 01:12:45 UTC
This time it's because the Javascript code written by C4/Barcodes/ValueBuilder.pm only works for the MARC basic editor. Fortunately, there's a very simple "fix" for this. Yikes... (In reply to David Cook from comment #2) > Fortunately, there's a very simple "fix" for this. Yikes... Oh I take that back. Fixes the Javascript but wrecks the styling :D Created attachment 171115 [details] [review] Bug 37854: Add fieldset.rows so that Javascript works This change adds a fieldset.rows that the Javascript produced by C4/Barcodes/ValueBuilder.pm will work here too like it does for /cgi-bin/koha/cataloguing/additem.pl and /cgi-bin/koha/acqui/neworderempty.pl The fieldset.rows element ruins the styling, so we add some context specific styling to the styling is preserved. Test plan: 0. Apply the patch 1. Set "autoBarcode" to "generated in the form <branchcode>yymm0001" 2. Create a vendor 3. Create a backet with "Create items when" set to "receiving an order" 4. Add an order (any order) 5. Close the basket 6. Receive the shipment 7. Click in the barcode field 8. Note that you get a barcode like CPL24090001 and not undefined24090001 Created attachment 171116 [details] [review] Bug 37854: Re-indent HTML (whitespace-only) This whitespace only change re-indents the HTML Created attachment 171234 [details] [review] Bug 37854: Add fieldset.rows so that Javascript works This change adds a fieldset.rows that the Javascript produced by C4/Barcodes/ValueBuilder.pm will work here too like it does for /cgi-bin/koha/cataloguing/additem.pl and /cgi-bin/koha/acqui/neworderempty.pl The fieldset.rows element ruins the styling, so we add some context specific styling to the styling is preserved. Test plan: 0. Apply the patch 1. Set "autoBarcode" to "generated in the form <branchcode>yymm0001" 2. Create a vendor 3. Create a backet with "Create items when" set to "receiving an order" 4. Add an order (any order) 5. Close the basket 6. Receive the shipment 7. Click in the barcode field 8. Note that you get a barcode like CPL24090001 and not undefined24090001 Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Created attachment 171235 [details] [review] Bug 37854: Re-indent HTML (whitespace-only) This whitespace only change re-indents the HTML Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Created attachment 174546 [details] [review] Bug 37854: Add fieldset.rows so that Javascript works This change adds a fieldset.rows that the Javascript produced by C4/Barcodes/ValueBuilder.pm will work here too like it does for /cgi-bin/koha/cataloguing/additem.pl and /cgi-bin/koha/acqui/neworderempty.pl The fieldset.rows element ruins the styling, so we add some context specific styling to the styling is preserved. Test plan: 0. Apply the patch 1. Set "autoBarcode" to "generated in the form <branchcode>yymm0001" 2. Create a vendor 3. Create a backet with "Create items when" set to "receiving an order" 4. Add an order (any order) 5. Close the basket 6. Receive the shipment 7. Click in the barcode field 8. Note that you get a barcode like CPL24090001 and not undefined24090001 Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 174547 [details] [review] Bug 37854: Re-indent HTML (whitespace-only) This whitespace only change re-indents the HTML Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.11! Well done everyone, thank you! |