Summary: | RecordSources_spec.ts is failing randomly | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Test Suite | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, lucas, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 38049 | ||
Attachments: | Bug 37917: Add some wait time for the intercepted request responses |
Description
Katrin Fischer
2024-09-13 13:38:03 UTC
Created attachment 171461 [details] [review] Bug 37917: Add some wait time for the intercepted request responses This patch introduces the `cy.wait(500)` we use in several other Cypress tests when an (intercepted) API request is made. This is very important when tables are being rendered as DataTables is particularly bulky and prone to take longer to finish loading the components if the CPU load is a bit high. I wasn't able to reproduce the problem very often, but you can test yourself: 1. Run: $ ktd --shell k$ run_cypress --spec t/cypress/integration/Admin/RecordSources_spec.ts 2. Run it many times => FAIL: At some point it fails, you can overload your computer to try 3. Apply the patch 4. Repeat 2 => SUCCESS: No failures :-D 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed for 24.11! Well done everyone, thank you! Can we get review before push on this kind of patches please? |