| Summary: | Remove ispermanent from returns.tt and branchtransfers.tt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Circulation | Assignee: | Andrew Fuerste-Henry <andrew> |
| Status: | Pushed to stable --- | QA Contact: | Chris Cormack <chris> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, kyle.m.hall, lucas, martin.renvoize, phil |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06
|
|
| Circulation function: | |||
| Attachments: |
Bug 38012: Remove ispermanent from retuns.tt and branchtransfers.tt
Bug 38012: Remove ispermanent from returns and branchtransfers Bug 38012: Remove ispermanent from returns and branchtransfers Bug 38012: Remove ispermanent from returns and branchtransfers |
||
|
Description
Andrew Fuerste-Henry
2024-09-26 14:16:26 UTC
We find a trace in 16.11.x : https://github.com/Koha-Community/Koha/blob/16.11.x/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt#L591 https://github.com/Koha-Community/Koha/blob/16.11.x/C4/Circulation.pm#L283 Created attachment 172114 [details] [review] Bug 38012: Remove ispermanent from retuns.tt and branchtransfers.tt No real test plan, exactly. These lines reference an error message that doesn't exist elsewhere in the code. Apply the patch and confirm checkins still work? Did you forget to commit the change to branchtransfers.tt? (In reply to Phil Ringnalda from comment #3) > Did you forget to commit the change to branchtransfers.tt? Oh, yes, I 100% did. Thanks and apologies :) Created attachment 172412 [details] [review] Bug 38012: Remove ispermanent from returns and branchtransfers To test: There should be no change in behavior, as this code is not referred to elsewhere in Koha. Make sure you can still do checkeckins and transfers. Comment on attachment 172114 [details] [review] Bug 38012: Remove ispermanent from retuns.tt and branchtransfers.tt >From ca71e8a2a8d66b29eca4b3110bc91b661d053e63 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrewfh@dubcolib.org> >Date: Fri, 27 Sep 2024 13:44:49 +0000 >Subject: [PATCH] Bug 38012: Remove ispermanent from retuns.tt and > branchtransfers.tt > >No real test plan, exactly. These lines reference an error message that doesn't exist elsewhere in the code. Apply the patch and confirm checkins still work? >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 6c132ef2b8..68d48353bc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -326,9 +326,6 @@ > [% IF ( errmsgloo.badbarcode ) %] > <p class="problem ret_badbarcode">No item with barcode: [% errmsgloo.msg | html %]</p> > [% END %] >- [% IF ( errmsgloo.ispermanent ) %] >- <p class="problem ret_ispermenant">Please return item to: [% Branches.GetName( errmsgloo.msg ) | html %]</p> >- [% END %] > [% IF ( errmsgloo.notissued ) %] > <p class="problem ret_notissued">Not checked out.</p> > [% END %] >-- >2.39.5 Created attachment 172413 [details] [review] Bug 38012: Remove ispermanent from returns and branchtransfers To test: There should be no change in behavior, as this code is not referred to elsewhere in Koha. Make sure you can still do checkeckins and transfers. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Created attachment 172933 [details] [review] Bug 38012: Remove ispermanent from returns and branchtransfers To test: There should be no change in behavior, as this code is not referred to elsewhere in Koha. Make sure you can still do checkeckins and transfers. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Nice clean-up, thanks! Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 |