Bug 38012

Summary: Remove ispermanent from returns.tt and branchtransfers.tt
Product: Koha Reporter: Andrew Fuerste-Henry <andrew>
Component: CirculationAssignee: Andrew Fuerste-Henry <andrew>
Status: Pushed to main --- QA Contact: Chris Cormack <chris>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, gmcharlt, kyle.m.hall, lucas, martin.renvoize, phil
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Attachments: Bug 38012: Remove ispermanent from retuns.tt and branchtransfers.tt
Bug 38012: Remove ispermanent from returns and branchtransfers
Bug 38012: Remove ispermanent from returns and branchtransfers
Bug 38012: Remove ispermanent from returns and branchtransfers

Description Andrew Fuerste-Henry 2024-09-26 14:16:26 UTC
The templates for returns and branch transfers both have code to display an error for the value "ispermanent," but that doesn't appear to actually be in use elsewhere in the code.

https://github.com/Koha-Community/Koha/blob/b4054dbb1578349cd1b8caa8fac9cbe6e32d20ea/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt#L329

https://github.com/Koha-Community/Koha/blob/b4054dbb1578349cd1b8caa8fac9cbe6e32d20ea/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt#L194

Looking at returns.pl, it makes reference to "ispermanent" in 3.0 but not 18.05. It seems like this is a remnant of a previous method for handling return behavior and transfers?
Comment 2 Andrew Fuerste-Henry 2024-09-27 13:48:45 UTC
Created attachment 172114 [details] [review]
Bug 38012: Remove ispermanent from retuns.tt and branchtransfers.tt

No real test plan, exactly. These lines reference an error message that doesn't exist elsewhere in the code. Apply the patch and confirm checkins still work?
Comment 3 Phil Ringnalda 2024-10-02 20:40:53 UTC
Did you forget to commit the change to branchtransfers.tt?
Comment 4 Andrew Fuerste-Henry 2024-10-02 20:56:03 UTC
(In reply to Phil Ringnalda from comment #3)
> Did you forget to commit the change to branchtransfers.tt?

Oh, yes, I 100% did. Thanks and apologies :)
Comment 5 Andrew Fuerste-Henry 2024-10-04 15:13:23 UTC
Created attachment 172412 [details] [review]
Bug 38012: Remove ispermanent from returns and branchtransfers

To test:
There should be no change in behavior, as this code is not referred to elsewhere in Koha. Make sure you can still do checkeckins and transfers.
Comment 6 Andrew Fuerste-Henry 2024-10-04 15:14:08 UTC
Comment on attachment 172114 [details] [review]
Bug 38012: Remove ispermanent from retuns.tt and branchtransfers.tt

>From ca71e8a2a8d66b29eca4b3110bc91b661d053e63 Mon Sep 17 00:00:00 2001
>From: Andrew Fuerste Henry <andrewfh@dubcolib.org>
>Date: Fri, 27 Sep 2024 13:44:49 +0000
>Subject: [PATCH] Bug 38012: Remove ispermanent from retuns.tt and
> branchtransfers.tt
>
>No real test plan, exactly. These lines reference an error message that doesn't exist elsewhere in the code. Apply the patch and confirm checkins still work?
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 6c132ef2b8..68d48353bc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -326,9 +326,6 @@
>                                         [% IF ( errmsgloo.badbarcode ) %]
>                                             <p class="problem ret_badbarcode">No item with barcode: [% errmsgloo.msg | html %]</p>
>                                         [% END %]
>-                                        [% IF ( errmsgloo.ispermanent ) %]
>-                                            <p class="problem ret_ispermenant">Please return item to: [% Branches.GetName( errmsgloo.msg ) | html %]</p>
>-                                        [% END %]
>                                         [% IF ( errmsgloo.notissued ) %]
>                                             <p class="problem ret_notissued">Not checked out.</p>
>                                         [% END %]
>-- 
>2.39.5
Comment 7 Phil Ringnalda 2024-10-04 15:20:37 UTC
Created attachment 172413 [details] [review]
Bug 38012: Remove ispermanent from returns and branchtransfers

To test:
There should be no change in behavior, as this code is not referred to elsewhere in Koha. Make sure you can still do checkeckins and transfers.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 8 Chris Cormack 2024-10-17 22:22:58 UTC
Created attachment 172933 [details] [review]
Bug 38012: Remove ispermanent from returns and branchtransfers

To test:
There should be no change in behavior, as this code is not referred to elsewhere in Koha. Make sure you can still do checkeckins and transfers.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 9 Katrin Fischer 2024-10-18 12:06:54 UTC
Nice clean-up, thanks!
Comment 10 Katrin Fischer 2024-10-18 12:27:44 UTC
Pushed for 24.11!

Well done everyone, thank you!