Bug 38048

Summary: po2json outputs a deprecation warning
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: I18N/L10NAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: f.demians, jonathan.druart, martin.renvoize, nick
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38031
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 38048: Remove po2json deprecation warning
Bug 38048: Remove po2json deprecation warning

Description Jonathan Druart 2024-10-01 08:58:23 UTC
(node:50086) [DEP0128] DeprecationWarning: Invalid 'main' field in '/kohadevbox/node_modules/po2json/package.json' of './lib/po2json'. Please either fix that or report it to the module author
(Use `node --trace-deprecation ...` to show where the warning was created)
Comment 1 Jonathan Druart 2024-10-01 09:00:13 UTC
Created attachment 172249 [details] [review]
Bug 38048: Remove po2json deprecation warning

(node:50086) [DEP0128] DeprecationWarning: Invalid 'main' field in '/kohadevbox/node_modules/po2json/package.json' of './lib/po2json'. Please either fix that or report it to the module author
(Use `node --trace-deprecation ...` to show where the warning was created)

See https://github.com/mikeedwards/po2json/issues/103
The project is not really maintained, so let's remove the warning on our
side as a quick workaround.

Test plan:
Run `koha-translate --update es-ES --dev kohadev`
Comment 2 Jonathan Druart 2024-10-01 09:00:36 UTC
You may need bug 38031 to test this.
Comment 3 Nick Clemens (kidclamp) 2024-10-01 13:30:50 UTC
Created attachment 172263 [details] [review]
Bug 38048: Remove po2json deprecation warning

(node:50086) [DEP0128] DeprecationWarning: Invalid 'main' field in '/kohadevbox/node_modules/po2json/package.json' of './lib/po2json'. Please either fix that or report it to the module author
(Use `node --trace-deprecation ...` to show where the warning was created)

See https://github.com/mikeedwards/po2json/issues/103
The project is not really maintained, so let's remove the warning on our
side as a quick workaround.

Test plan:
Run `koha-translate --update es-ES --dev kohadev`

WNC amended patch - tidied

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Martin Renvoize (ashimema) 2024-10-28 11:12:05 UTC
Bug 37303 reverted, we no longer need this.