Summary: | Holidays table doesn't order by date correcly | ||
---|---|---|---|
Product: | Koha | Reporter: | Frédéric Demians <f.demians> |
Component: | Tools | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, duncan, indradg, m.de.rooy, paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed fix
Patch that failed QA Self-signed patch for table header Bug 3806 - Holidays table doesn't order by date correcly Signed patch |
Description
Chris Cormack
2010-05-21 01:15:13 UTC
This patch removes the table sorter from all but the Exceptions table, but I'm not seeing any logical sort on those tables now. The Exceptions table still has a table sorter, and still doesn't have any code added for handling different date formats. I don't see what we gain from these changes. Created attachment 6612 [details] [review] Proposed fix Adding dateformat filter to JavaScript tablesorter configurations. Created attachment 6631 [details] [review] Patch that failed QA QA Comment: This does not work when dateformat is metric. The list is not sorted well (in the repeatable yearly holidays). I tried dd/mm/yyyy instead of uk, but that does not work either. Problem is that the column does not contain a date but only dd/mm and that is not a valid date format. Pragmatic solution would be to add the current year in the repeatable yearly holidays. That makes the date complete, helping jQuery to sort them well. Found another related bug for the header of that table. Included a follow up to correct check on metric in template. Created attachment 7050 [details] [review] Self-signed patch for table header Trivial one line change. Created attachment 7353 [details] [review] Bug 3806 - Holidays table doesn't order by date correcly Adding dateformat filter to JavaScript tablesorter configurations. Follow-up adds a custom date parser for dates without year ("01/10") Created attachment 7383 [details] [review] Signed patch QA Comment: Did signoff already. Code looks good. Only point [cw]ould be use of tablesorter in view of new datatables approach. Since this patch refers to solving this particular problem and not refactoring code, I am marking it as Passed QA anyhow. This fix was included in the 3.6.x branch prior to 3.6.4. |