| Summary: | Missing use after Bug 25812 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | SIP2 | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | CLOSED FIXED | QA Contact: | Paul Derscheid <me> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | blawlor, lucas, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | 25812 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 38073: Add missing use in C4/SIP/ILS.pm
Bug 38073: Add missing use in C4/SIP/ILS.pm Bug 38073: Add missing use in C4/SIP/ILS.pm |
||
|
Description
Fridolin Somers
2024-10-03 12:57:44 UTC
Created attachment 172582 [details] [review] Bug 38073: Add missing use in C4/SIP/ILS.pm Bug 25812 added some code with Koha::XXX objects. They must be added in used modules Test plan : Check SIP server still runs Created attachment 173083 [details] [review] Bug 38073: Add missing use in C4/SIP/ILS.pm Bug 25812 added some code with Koha::XXX objects. They must be added in used modules Test plan : Check SIP server still runs Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Test notes: In ktd repo edit docker-compose-light.yml Under services: koha: ports: add port - "6001:6001" In ktd --shell install telnet sudo apt update && sudo apt install telnet Set a patron username and password to test SIP. I used Henry Acevedo username:ace password: 1234Abcd Apply patch and restart_all Connect to SIP server: telnet localhost 6001 Authenticate as SIP user: 9300CNterm1|COterm1|CPCPL| Send patron info request: 6300020060329 201700Y AOCPL|AAace|AD1234Abcd| Confirm response: 64 00020241021 202455000000000000000000000000AOCPL|AA23529000035676|AEHenry Acevedo|BLY|CQY|BHUSD|BV0|CC5|BD4345 Library Rd. Springfield, MA 44224|BF(212) 555-1212|PB19580530|PCS|PIY|AFGreetings from Koha. | I'd be happy to test more is there is a more specific test plan. Created attachment 173920 [details] [review] Bug 38073: Add missing use in C4/SIP/ILS.pm Bug 25812 added some code with Koha::XXX objects. They must be added in used modules Test plan : Check SIP server still runs Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Pushed for 24.11! Well done everyone, thank you! Merge conflicts with 24.05.x, no backport. |