Bug 38184

Summary: OpacTrustedCheckout module does not show due date
Product: Koha Reporter: Aleisha Amohia <aleisha>
Component: OPACAssignee: Aleisha Amohia <aleisha>
Status: Pushed to main --- QA Contact: Owen Leonard <oleonard>
Severity: minor    
Priority: P5 - low CC: david, martin.renvoize
Version: MainKeywords: rel_23_11_candidate
Hardware: All   
OS: All   
GIT URL: Change sponsored?: Sponsored
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes the self checkout pop-up window when using the OpacTrustedCheckout system preference - the due date is now shown in the due date column, previously it was not showing the due date.
Version(s) released in:
25.05.00
Circulation function:
Bug Depends on: 39313    
Bug Blocks:    
Attachments: Bug 38184: Show due date on OpacTrustedCheckout modal
Bug 38184: Show due date on OpacTrustedCheckout modal
Bug 38184: (follow-up) Correct the number of tests
Bug 38184: Show due date on OpacTrustedCheckout modal
Bug 38184: (follow-up) Correct the number of tests

Description Aleisha Amohia 2024-10-16 04:20:13 UTC
To reproduce:

1. Enabled OpacTrustedCheckout system preference
2. Search for an item and get the barcode
3. Go to the OPAC
4. Click the Self-checkout button at the top
5. Enter the barcode and submit
6. Notice that the due date does not show in the modal, even though the due date was correctly set
Comment 1 Aleisha Amohia 2025-03-13 23:36:42 UTC
Created attachment 179294 [details] [review]
Bug 38184: Show due date on OpacTrustedCheckout modal

This fixes checkout fields being made available to the public API.

Note: This depends on the fix at Bug 39313, so make sure you apply that first.

To test:

1. Enabled OpacTrustedCheckout system preference
2. Search for an item and get the barcode
3. Go to the OPAC
4. Click the Self-checkout button at the top
5. Enter the barcode and submit
6. Notice that the due date does not show in the modal, even though the due date was correctly set

7. Apply the patch and restart services

8. Go to the staff interface and check in your barcode
9. Repeat steps 3-5
10. Confirm the due date does show correctly in the modal

11. Confirm tests pass t/db_dependent/Koha/Checkout.t

Sponsored-by: Reserve Bank of New Zealand
Comment 2 Owen Leonard 2025-03-14 12:37:34 UTC
Created attachment 179325 [details] [review]
Bug 38184: Show due date on OpacTrustedCheckout modal

This fixes checkout fields being made available to the public API.

Note: This depends on the fix at Bug 39313, so make sure you apply that
first.

To test:

1. Enabled OpacTrustedCheckout system preference
2. Search for an item and get the barcode
3. Go to the OPAC
4. Click the Self-checkout button at the top
5. Enter the barcode and submit
6. Notice that the due date does not show in the modal, even though the
   due date was correctly set

7. Apply the patch and restart services

8. Go to the staff interface and check in your barcode
9. Repeat steps 3-5
10. Confirm the due date does show correctly in the modal

11. Confirm tests pass t/db_dependent/Koha/Checkout.t

Sponsored-by: Reserve Bank of New Zealand
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Owen Leonard 2025-03-14 12:37:36 UTC
Created attachment 179326 [details] [review]
Bug 38184: (follow-up) Correct the number of tests
Comment 4 David Nind 2025-03-16 19:36:42 UTC
Created attachment 179374 [details] [review]
Bug 38184: Show due date on OpacTrustedCheckout modal

This fixes checkout fields being made available to the public API.

Note: This depends on the fix at Bug 39313, so make sure you apply that
first.

To test:

1. Enabled OpacTrustedCheckout system preference
2. Search for an item and get the barcode
3. Go to the OPAC
4. Click the Self-checkout button at the top
5. Enter the barcode and submit
6. Notice that the due date does not show in the modal, even though the
   due date was correctly set

7. Apply the patch and restart services

8. Go to the staff interface and check in your barcode
9. Repeat steps 3-5
10. Confirm the due date does show correctly in the modal

11. Confirm tests pass t/db_dependent/Koha/Checkout.t

Sponsored-by: Reserve Bank of New Zealand
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2025-03-16 19:36:45 UTC
Created attachment 179375 [details] [review]
Bug 38184: (follow-up) Correct the number of tests

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2025-03-16 19:39:56 UTC
I've added my sign off, so perhaps Owen's could be counted as QA?
Comment 7 Aleisha Amohia 2025-03-19 22:02:10 UTC
Yes I think so!
Comment 8 Katrin Fischer 2025-03-20 08:04:26 UTC
Pushed for 25.05!

Well done everyone, thank you!