Summary: | Cancelling a hold from the holds over tab shouldn't trigger "return to home" transfer on a lost item | ||
---|---|---|---|
Product: | Koha | Reporter: | Emily Lamancusa (emlam) <emily.lamancusa> |
Component: | Hold requests | Assignee: | Emily Lamancusa (emlam) <emily.lamancusa> |
Status: | Needs documenting --- | QA Contact: | Chris Cormack <chris> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00,24.05.06
|
Circulation function: | |
Attachments: |
Bug 38186: Don't initiate transfer when cancelling hold on lost item
Bug 38186: Don't initiate transfer when cancelling hold on lost item Bug 38186: Don't initiate transfer when cancelling hold on lost item |
Description
Emily Lamancusa (emlam)
2024-10-16 13:42:50 UTC
Created attachment 172821 [details] [review] Bug 38186: Don't initiate transfer when cancelling hold on lost item To test: 0. In the Circulation Rules, set the default return policy to "item returns home (default settings have this already) 1. Find an item belonging to a branch other than the logged-in branch 2. Place a hold on that biblio record for pickup at the logged-in branch 3. Check in the item to set the hold to waiting 4. Set the expiration date to a date in the past To do this in KTD: ktd --shell koha-mysql kohadev UPDATE reserves SET expirationdate = < yesterday's date >; 5. Set a lost status on the item 6. Go to Circulation > Holds awaiting pickup --> The hold should appear on the "holds waiting past their expiration date" tab 7. Click the "Cancel and return to <homebranch>" button next to the hold 8. Open the biblio record for the item --> Note that the lost status is gone and the item shows as in-transit 9. Apply patch 10. Repeat steps 2-8 on the same item --> This time, the item is still lost and is not in-transit Really, this whole workflow could use some refactoring... Fixing this obvious bug for now, but I'll try to make time to come back to this next cycle. Created attachment 174433 [details] [review] Bug 38186: Don't initiate transfer when cancelling hold on lost item To test: 0. In the Circulation Rules, set the default return policy to "item returns home (default settings have this already) 1. Find an item belonging to a branch other than the logged-in branch 2. Place a hold on that biblio record for pickup at the logged-in branch 3. Check in the item to set the hold to waiting 4. Set the expiration date to a date in the past To do this in KTD: ktd --shell koha-mysql kohadev UPDATE reserves SET expirationdate = < yesterday's date >; 5. Set a lost status on the item 6. Go to Circulation > Holds awaiting pickup --> The hold should appear on the "holds waiting past their expiration date" tab 7. Click the "Cancel and return to <homebranch>" button next to the hold 8. Open the biblio record for the item --> Note that the lost status is gone and the item shows as in-transit 9. Apply patch 10. Repeat steps 2-8 on the same item --> This time, the item is still lost and is not in-transit Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 174537 [details] [review] Bug 38186: Don't initiate transfer when cancelling hold on lost item To test: 0. In the Circulation Rules, set the default return policy to "item returns home (default settings have this already) 1. Find an item belonging to a branch other than the logged-in branch 2. Place a hold on that biblio record for pickup at the logged-in branch 3. Check in the item to set the hold to waiting 4. Set the expiration date to a date in the past To do this in KTD: ktd --shell koha-mysql kohadev UPDATE reserves SET expirationdate = < yesterday's date >; 5. Set a lost status on the item 6. Go to Circulation > Holds awaiting pickup --> The hold should appear on the "holds waiting past their expiration date" tab 7. Click the "Cancel and return to <homebranch>" button next to the hold 8. Open the biblio record for the item --> Note that the lost status is gone and the item shows as in-transit 9. Apply patch 10. Repeat steps 2-8 on the same item --> This time, the item is still lost and is not in-transit Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 This makes sens, but I prefer not impact 23.11.x for stability |