| Summary: | Remove dead code to delete authorities in authorities/authorities.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Phil Ringnalda <phil> |
| Component: | Architecture, internals, and plumbing | Assignee: | Phil Ringnalda <phil> |
| Status: | RESOLVED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06
|
|
| Circulation function: | |||
| Attachments: |
Bug 38200: Remove dead code to delete authorities in authorities/authorities.pl
Bug 38200: Remove dead code to delete authorities in authorities/authorities.pl Bug 38200: Remove dead code to delete authorities in authorities/authorities.pl |
||
|
Description
Phil Ringnalda
2024-10-18 03:11:07 UTC
Created attachment 172940 [details] [review] Bug 38200: Remove dead code to delete authorities in authorities/authorities.pl It has probably never been used. There's no sign of any UI to delete from the authority editor or auth_finder in the last 13 years of templates, and it was unused when it landed; the patch that actually made the first patch work, a month later, put deleting authorities in authorities_home.pl, where it has been ever since. It certainly hasn't been used since bug 17600 landed in 2021, since it doesn't 'use C4::AuthoritiesMarc qw( DelAuthority );' and so if you try to use it you just get an error for your trouble. Sponsored-by: Chetco Community Public Library Created attachment 173171 [details] [review] Bug 38200: Remove dead code to delete authorities in authorities/authorities.pl It has probably never been used. There's no sign of any UI to delete from the authority editor or auth_finder in the last 13 years of templates, and it was unused when it landed; the patch that actually made the first patch work, a month later, put deleting authorities in authorities_home.pl, where it has been ever since. It certainly hasn't been used since bug 17600 landed in 2021, since it doesn't 'use C4::AuthoritiesMarc qw( DelAuthority );' and so if you try to use it you just get an error for your trouble. Sponsored-by: Chetco Community Public Library Signed-off-by: Yanjun Li <yanjun.li@bywatersolutions.com> Created attachment 173193 [details] [review] Bug 38200: Remove dead code to delete authorities in authorities/authorities.pl It has probably never been used. There's no sign of any UI to delete from the authority editor or auth_finder in the last 13 years of templates, and it was unused when it landed; the patch that actually made the first patch work, a month later, put deleting authorities in authorities_home.pl, where it has been ever since. It certainly hasn't been used since bug 17600 landed in 2021, since it doesn't 'use C4::AuthoritiesMarc qw( DelAuthority );' and so if you try to use it you just get an error for your trouble. Sponsored-by: Chetco Community Public Library Signed-off-by: Yanjun Li <yanjun.li@bywatersolutions.com> Amended-by: Jonathan Druart tidy Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 I prefer not backport to 23.11.x for stability Removes code which has never done anything, nothing to document. |