Bug 38243

Summary: Datatable's header_filter is unused
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: RESOLVED FIXED QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: minor    
Priority: P5 - low CC: david, gmcharlt, lucas, martin.renvoize, tomascohen
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:
Bug Depends on: 32401    
Bug Blocks:    
Attachments: Bug 38243: Remove DT's header_filter custom param
Bug 38243: Remove options.query_parameters
Bug 38243: Remove DT's header_filter custom param
Bug 38243: Remove options.query_parameters
Bug 38243: Remove DT's header_filter custom param
Bug 38243: Remove options.query_parameters

Description Jonathan Druart 2024-10-23 14:47:49 UTC
It seems to be a leftover from bug 32401, the code does not make sense:

 569                 if(options.header_filter) {
 570                     options.query_parameters = query_parameters;
 571                 } else {
 572                     dataSet.q = query_parameters;
 573                     delete options.query_parameters;
 574                 }

Then options.query_parameters is never used.
Comment 1 Jonathan Druart 2024-10-23 14:51:41 UTC
Created attachment 173221 [details] [review]
Bug 38243: Remove DT's header_filter custom param

It seems to be a leftover from bug 32401, the code does not make sense:

 569                 if(options.header_filter) {
 570                     options.query_parameters = query_parameters;
 571                 } else {
 572                     dataSet.q = query_parameters;
 573                     delete options.query_parameters;
 574                 }

Then options.query_parameters is never used.
Comment 2 Jonathan Druart 2024-10-23 14:51:44 UTC
Created attachment 173222 [details] [review]
Bug 38243: Remove options.query_parameters

This is never passed: `git grep query_parameters`
Comment 3 David Nind 2024-10-23 18:18:15 UTC
Created attachment 173234 [details] [review]
Bug 38243: Remove DT's header_filter custom param

It seems to be a leftover from bug 32401, the code does not make sense:

 569                 if(options.header_filter) {
 570                     options.query_parameters = query_parameters;
 571                 } else {
 572                     dataSet.q = query_parameters;
 573                     delete options.query_parameters;
 574                 }

Then options.query_parameters is never used.

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2024-10-23 18:18:18 UTC
Created attachment 173235 [details] [review]
Bug 38243: Remove options.query_parameters

This is never passed: `git grep query_parameters`

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2024-10-23 18:20:04 UTC
Not sure exactly how to test, but after the patch is applied a 'git grep options.query_parameters' returns no results.

Feel free to change back to 'Needs Signoff' if that is not sufficient.
Comment 6 Martin Renvoize (ashimema) 2024-10-28 11:09:16 UTC
Created attachment 173513 [details] [review]
Bug 38243: Remove DT's header_filter custom param

It seems to be a leftover from bug 32401, the code does not make sense:

 569                 if(options.header_filter) {
 570                     options.query_parameters = query_parameters;
 571                 } else {
 572                     dataSet.q = query_parameters;
 573                     delete options.query_parameters;
 574                 }

Then options.query_parameters is never used.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize (ashimema) 2024-10-28 11:09:18 UTC
Created attachment 173514 [details] [review]
Bug 38243: Remove options.query_parameters

This is never passed: `git grep query_parameters`

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize (ashimema) 2024-10-28 11:09:33 UTC
Confirmed, working, Passing QA
Comment 9 Katrin Fischer 2024-10-29 15:18:24 UTC
Pushed for 24.11!

Well done everyone, thank you!