|
Description
Martin Renvoize (ashimema)
2024-10-25 13:08:30 UTC
Love this. Been meaning to file this for ages. Created attachment 173507 [details] [review] Bug 38273: Make Koha::Object->discard_changes chainable Created attachment 173528 [details] [review] Bug 38273: Make Koha::Object->discard_changes chainable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 173529 [details] [review] Bug 38273: Make sure same object is returned This patch adds a test to make sure the same object is returned. A code change is also added to make sure the tests pass. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 173538 [details] [review] Bug 38273: Make Koha::Object->discard_changes chainable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 173539 [details] [review] Bug 38273: Make sure same object is returned This patch adds a test to make sure the same object is returned. A code change is also added to make sure the tests pass. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Blimey!.. This went through quick!.. nice one chaps. (In reply to Martin Renvoize (ashimema) from comment #7) > Blimey!.. This went through quick!.. nice one chaps. Let's turn them all around that quickly :D Pushed for 24.11! Well done everyone, thank you! Created attachment 173705 [details] [review] Bug 38273: Adjust t/db_dependent/api/v1/holds.t (In reply to Pedro Amorim from comment #10) > Created attachment 173705 [details] [review] [review] > Bug 38273: Adjust t/db_dependent/api/v1/holds.t Good catch! Follow-up pushed to main, fingers crossed! Thanks, Pedro! Failing tests on 24.05.x with this patch set applied. No backport. |