Bug 38290

Summary: Add library group limits to vendors
Product: Koha Reporter: Matt Blenkinsop <matt.blenkinsop>
Component: AcquisitionsAssignee: Matt Blenkinsop <matt.blenkinsop>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: clemens.tubach, david, jonathan.field, michaela.sieber
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 23005, 38208, 38262, 38291    
Bug Blocks:    
Attachments: Bug 38290: Add a column for library group visibility
Bug 38290: DBIC file
Bug 38290: Add library group limit classes
Bug 38290: Add library group api client
Bug 38290: Add fields to the UI for CRUD
Bug 38290: Add cypress tests
Bug 38290: Set lib_group_visibility as null
Bug 38290: Add a column for library group visibility
Bug 38290: DBIC file
Bug 38290: Add library group limit classes
Bug 38290: Add library group api client
Bug 38290: Add fields to the UI for CRUD
Bug 38290: Add cypress tests
Bug 38290: Set lib_group_visibility as null
Bug 38290: Use parameters to set/fetch values
Bug 38290: Add unit tests
Bug 38290: Add a column for library group visibility
Bug 38290: DBIC file
Bug 38290: Add library group limit classes
Bug 38290: Add library group api client
Bug 38290: Add fields to the UI for CRUD
Bug 38290: Add cypress tests
Bug 38290: Set lib_group_visibility as null
Bug 38290: Use parameters to set/fetch values
Bug 38290: Add unit tests
Bug 38290: Add a column for library group visibility
Bug 38290: DBIC file
Bug 38290: Add library group limit classes
Bug 38290: Add library group api client
Bug 38290: Add fields to the UI for CRUD
Bug 38290: Add cypress tests
Bug 38290: Set lib_group_visibility as null
Bug 38290: Use parameters to set/fetch values
Bug 38290: Add unit tests

Description Matt Blenkinsop 2024-10-29 16:40:18 UTC
It should be possible to limit which vendors can be seen based on library groups
Comment 1 Katrin Fischer 2024-10-29 16:47:16 UTC
That would have been very helpful for us in the past. For some libraries the contacts etc. are not the same and having "duplicate" vendors with no way to see which libraries a vendor "belongs" to makes things difficult currently.

Can you share some more specifics about the implementation?
Comment 2 Matt Blenkinsop 2024-10-29 16:59:12 UTC
In short you will be able to set a list of library groups on a vendor record that determine which groups this vendor is visible to. When a user requests a page relevant to vendors the system will return a filtered list based on the user's logged in branchcode. Essentially if the user's branchcode exists in a library group then any vendors attached to that group (or any parent groups) will be returned but any attached to groups where that branch does not exits will be filtered out
Comment 3 Katrin Fischer 2024-10-30 06:58:48 UTC
Thanks Matt, I was hoping it would be able to have a vendor shared by multiple libraries, which this implementation would allow.
Comment 4 Matt Blenkinsop 2024-12-04 10:21:49 UTC Comment hidden (obsolete)
Comment 5 Matt Blenkinsop 2024-12-04 10:21:51 UTC Comment hidden (obsolete)
Comment 6 Matt Blenkinsop 2024-12-04 10:21:53 UTC Comment hidden (obsolete)
Comment 7 Matt Blenkinsop 2024-12-04 10:21:56 UTC Comment hidden (obsolete)
Comment 8 Matt Blenkinsop 2024-12-04 10:21:58 UTC Comment hidden (obsolete)
Comment 9 Matt Blenkinsop 2024-12-04 10:22:01 UTC Comment hidden (obsolete)
Comment 10 Matt Blenkinsop 2024-12-04 10:22:04 UTC Comment hidden (obsolete)
Comment 11 Matt Blenkinsop 2024-12-19 16:30:24 UTC Comment hidden (obsolete)
Comment 12 Matt Blenkinsop 2024-12-19 16:30:27 UTC Comment hidden (obsolete)
Comment 13 Matt Blenkinsop 2024-12-19 16:30:29 UTC Comment hidden (obsolete)
Comment 14 Matt Blenkinsop 2024-12-19 16:30:32 UTC Comment hidden (obsolete)
Comment 15 Matt Blenkinsop 2024-12-19 16:30:34 UTC Comment hidden (obsolete)
Comment 16 Matt Blenkinsop 2024-12-19 16:30:37 UTC Comment hidden (obsolete)
Comment 17 Matt Blenkinsop 2024-12-19 16:30:39 UTC Comment hidden (obsolete)
Comment 18 Matt Blenkinsop 2024-12-19 16:30:42 UTC Comment hidden (obsolete)
Comment 19 Matt Blenkinsop 2024-12-19 16:30:44 UTC Comment hidden (obsolete)
Comment 20 Matt Blenkinsop 2025-04-03 13:55:00 UTC Comment hidden (obsolete)
Comment 21 Matt Blenkinsop 2025-04-03 13:55:03 UTC Comment hidden (obsolete)
Comment 22 Matt Blenkinsop 2025-04-03 13:55:07 UTC Comment hidden (obsolete)
Comment 23 Matt Blenkinsop 2025-04-03 13:55:11 UTC Comment hidden (obsolete)
Comment 24 Matt Blenkinsop 2025-04-03 13:55:17 UTC Comment hidden (obsolete)
Comment 25 Matt Blenkinsop 2025-04-03 13:55:22 UTC Comment hidden (obsolete)
Comment 26 Matt Blenkinsop 2025-04-03 13:55:25 UTC Comment hidden (obsolete)
Comment 27 Matt Blenkinsop 2025-04-03 13:55:28 UTC Comment hidden (obsolete)
Comment 28 Matt Blenkinsop 2025-04-03 13:55:34 UTC Comment hidden (obsolete)
Comment 29 Matt Blenkinsop 2025-04-03 13:56:16 UTC
Test plan to follow
Comment 30 Matt Blenkinsop 2025-05-20 10:51:40 UTC
Created attachment 182656 [details] [review]
Bug 38290: Add a column for library group visibility

(cherry picked from commit a0a31abca79ae7c0e282211724eb995bd92e5b9b)
Comment 31 Matt Blenkinsop 2025-05-20 10:51:43 UTC
Created attachment 182657 [details] [review]
Bug 38290: DBIC file
Comment 32 Matt Blenkinsop 2025-05-20 10:51:46 UTC
Created attachment 182658 [details] [review]
Bug 38290: Add library group limit classes
Comment 33 Matt Blenkinsop 2025-05-20 10:51:49 UTC
Created attachment 182659 [details] [review]
Bug 38290: Add library group api client
Comment 34 Matt Blenkinsop 2025-05-20 10:51:53 UTC
Created attachment 182660 [details] [review]
Bug 38290: Add fields to the UI for CRUD
Comment 35 Matt Blenkinsop 2025-05-20 10:51:56 UTC
Created attachment 182661 [details] [review]
Bug 38290: Add cypress tests

(cherry picked from commit e270a21e248c58ae7f402628252c9589dccb618e)
Comment 36 Matt Blenkinsop 2025-05-20 10:52:00 UTC
Created attachment 182662 [details] [review]
Bug 38290: Set lib_group_visibility as null
Comment 37 Matt Blenkinsop 2025-05-20 10:52:03 UTC
Created attachment 182663 [details] [review]
Bug 38290: Use parameters to set/fetch values
Comment 38 Matt Blenkinsop 2025-05-20 10:52:06 UTC
Created attachment 182664 [details] [review]
Bug 38290: Add unit tests

prove t/db_dependent/Koha/*/Limit/LibraryGroup.t
Comment 39 David Nind 2025-06-29 22:01:01 UTC
(In reply to Matt Blenkinsop from comment #29)
> Test plan to follow

A test plan would be really helpful 8-)