Bug 38291

Summary: Add GET /library_groups
Product: Koha Reporter: Matt Blenkinsop <matt.blenkinsop>
Component: REST APIAssignee: Matt Blenkinsop <matt.blenkinsop>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: brendan, caroline.cyr-la-rose, dcook, lisette, lucas, tomascohen
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 38290    
Attachments: Bug 38291: Add an endpoint to list library groups
Bug 38291: Add a unit test
Bug 38291: Add an endpoint to list library groups
Bug 38291: Add a unit test

Description Matt Blenkinsop 2024-10-29 16:56:29 UTC
We should have an endpoint to list library groups
Comment 1 Matt Blenkinsop 2024-12-04 10:23:04 UTC
Created attachment 175162 [details] [review]
Bug 38291: Add an endpoint to list library groups

(cherry picked from commit cd2440165f62e96410df9d11bb3aab578d028016)
Comment 2 Matt Blenkinsop 2024-12-04 10:23:06 UTC
Created attachment 175163 [details] [review]
Bug 38291: Add a unit test

(cherry picked from commit 9f9c2a0678c42ec5ac4016dd2ef603232150e770)
Comment 3 Lisette Scheer 2025-01-07 16:01:33 UTC
Do you have a test plan?
Comment 4 Brendan Gallagher 2025-04-03 09:44:31 UTC
Created attachment 180484 [details] [review]
Bug 38291: Add an endpoint to list library groups

(cherry picked from commit cd2440165f62e96410df9d11bb3aab578d028016)
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 5 Brendan Gallagher 2025-04-03 09:44:34 UTC
Created attachment 180485 [details] [review]
Bug 38291: Add a unit test

(cherry picked from commit 9f9c2a0678c42ec5ac4016dd2ef603232150e770)
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 6 Brendan Gallagher 2025-04-03 09:45:14 UTC
Code looks good enough to move to QA for review (there are a few QA followups but those are trivial - so moving this forward)
Comment 7 Lucas Gass (lukeg) 2025-08-22 16:16:47 UTC
A couple of problems the QA tool spotted with api/v1/library_groups.t

-Permission seems wrong:

   FAIL	  file_permissions
		File must have the exec flag


-It may not be tidy: 

   FAIL	  tidiness
		File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/api/v1/library_groups.t`


A test is failing after running yarn build:

Running tests (1)
	* Proving /kohadevbox/koha/t/db_dependent/api/v1/library_groups.t FAIL

    #   Failed test 'SWAGGER3.2.2'
    #   at /kohadevbox/koha/t/db_dependent/api/v1/library_groups.t line 72.
    #          got: '500'
    #     expected: '200'
     # Looks like you planned 3 tests but ran 2.
    # Looks like you failed 1 test of 2 run.
Comment 8 Lucas Gass (lukeg) 2025-08-27 19:16:44 UTC
*** Bug 34420 has been marked as a duplicate of this bug. ***