| Summary: | Add GET /library_groups | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
| Component: | REST API | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | brendan, caroline.cyr-la-rose, dcook, lisette, lucas, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 38290 | ||
| Attachments: |
Bug 38291: Add an endpoint to list library groups
Bug 38291: Add a unit test Bug 38291: Add an endpoint to list library groups Bug 38291: Add a unit test Bug 38291: Add an endpoint to list library groups Bug 38291: Add a unit test |
||
|
Description
Matt Blenkinsop
2024-10-29 16:56:29 UTC
Created attachment 175162 [details] [review] Bug 38291: Add an endpoint to list library groups (cherry picked from commit cd2440165f62e96410df9d11bb3aab578d028016) Created attachment 175163 [details] [review] Bug 38291: Add a unit test (cherry picked from commit 9f9c2a0678c42ec5ac4016dd2ef603232150e770) Do you have a test plan? Created attachment 180484 [details] [review] Bug 38291: Add an endpoint to list library groups (cherry picked from commit cd2440165f62e96410df9d11bb3aab578d028016) Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 180485 [details] [review] Bug 38291: Add a unit test (cherry picked from commit 9f9c2a0678c42ec5ac4016dd2ef603232150e770) Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Code looks good enough to move to QA for review (there are a few QA followups but those are trivial - so moving this forward) A couple of problems the QA tool spotted with api/v1/library_groups.t
-Permission seems wrong:
FAIL file_permissions
File must have the exec flag
-It may not be tidy:
FAIL tidiness
File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/api/v1/library_groups.t`
A test is failing after running yarn build:
Running tests (1)
* Proving /kohadevbox/koha/t/db_dependent/api/v1/library_groups.t FAIL
# Failed test 'SWAGGER3.2.2'
# at /kohadevbox/koha/t/db_dependent/api/v1/library_groups.t line 72.
# got: '500'
# expected: '200'
# Looks like you planned 3 tests but ran 2.
# Looks like you failed 1 test of 2 run.
*** Bug 34420 has been marked as a duplicate of this bug. *** Created attachment 188411 [details] [review] Bug 38291: Add an endpoint to list library groups (cherry picked from commit cd2440165f62e96410df9d11bb3aab578d028016) Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Created attachment 188412 [details] [review] Bug 38291: Add a unit test (cherry picked from commit 9f9c2a0678c42ec5ac4016dd2ef603232150e770) Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> |