| Summary: | Item's replacement price not set to defaultreplacecost if 0.00 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | Pushed to main --- | QA Contact: | Aleisha Amohia <aleisha> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | aleisha, tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37943 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 38303: Set item's replacement price to defaultreplacecost if 0.00
Bug 38303: Set item's replacement price to defaultreplacecost if 0.00 Bug 38303: Set item's replacement price to defaultreplacecost if 0.00 |
||
Created attachment 173722 [details] [review] Bug 38303: Set item's replacement price to defaultreplacecost if 0.00 No idea if this is a real bug. This code is fixing the following test failure: t/db_dependent/Circulation/CalcFine.t .. 1/7 # Failed test 'Amount is calculated correctly' # at t/db_dependent/Circulation/CalcFine.t line 271. # got: '0' # expected: '6' # Looks like you failed 1 test of 2. Created attachment 173730 [details] [review] Bug 38303: Set item's replacement price to defaultreplacecost if 0.00 No idea if this is a real bug. This code is fixing the following test failure: t/db_dependent/Circulation/CalcFine.t .. 1/7 # Failed test 'Amount is calculated correctly' # at t/db_dependent/Circulation/CalcFine.t line 271. # got: '0' # expected: '6' # Looks like you failed 1 test of 2. Signed-off-by: David Nind <david@davidnind.com> Not sure how, but bisecting pointed to bug 37943. Yes, because of the discard_changes call. (In reply to Jonathan Druart from comment #4) > Yes, because of the discard_changes call. Isn't this highlighting something else? Created attachment 173746 [details] [review] Bug 38303: Set item's replacement price to defaultreplacecost if 0.00 No idea if this is a real bug. This code is fixing the following test failure: t/db_dependent/Circulation/CalcFine.t .. 1/7 # Failed test 'Amount is calculated correctly' # at t/db_dependent/Circulation/CalcFine.t line 271. # got: '0' # expected: '6' # Looks like you failed 1 test of 2. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> (In reply to Tomás Cohen Arazi (tcohen) from comment #5) > (In reply to Jonathan Druart from comment #4) > > Yes, because of the discard_changes call. > > Isn't this highlighting something else? Maybe, but I didn't find anything bad. It highlighted this problem at least. Pushed for 24.11! Well done everyone, thank you! |
Caught by a failing test t/db_dependent/Circulation/CalcFine.t .. 1/7 # Failed test 'Amount is calculated correctly' # at t/db_dependent/Circulation/CalcFine.t line 271. # got: '0' # expected: '6' # Looks like you failed 1 test of 2. introduced by bug 37943