Summary: | Wrong comment in t/db_dependent/api/v1/erm_users.t | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Test Suite | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, fridolin.somers, jesse, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes ERM user tests in t/db_dependent/api/v1/erm_users.t. It was not correctly testing the permissions for listing users. It was supposed to check that two users were returned, but only one was returned.
|
|
Version(s) released in: |
24.11.00,24.05.06,23.11.11
|
Circulation function: | |
Attachments: |
Bug 38322: Adust tests
Bug 38322: Adjust tests Bug 38322: Adjust tests Bug 38322: (QA follow-up) Fix spelling |
Description
Nick Clemens (kidclamp)
2024-11-01 12:53:08 UTC
Created attachment 173873 [details] [review] Bug 38322: Adust tests Created attachment 174297 [details] [review] Bug 38322: Adjust tests Signed-off-by: David Nind <david@davidnind.com> Tests pass before and after the patch: prove t/db_dependent/api/v1/erm_users.t Created attachment 174450 [details] [review] Bug 38322: Adjust tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 174451 [details] [review] Bug 38322: (QA follow-up) Fix spelling Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 I've added a release note, but I'm not sure that I have described what the problem was, and what was fixed. Pushed to 23.11.x for 23.11.11 Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. |