Bug 38322

Summary: Wrong comment in t/db_dependent/api/v1/erm_users.t
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Test SuiteAssignee: Nick Clemens (kidclamp) <nick>
Status: RESOLVED FIXED QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: david, fridolin.somers, jesse, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes ERM user tests in t/db_dependent/api/v1/erm_users.t. It was not correctly testing the permissions for listing users. It was supposed to check that two users were returned, but only one was returned.
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:
Attachments: Bug 38322: Adust tests
Bug 38322: Adjust tests
Bug 38322: Adjust tests
Bug 38322: (QA follow-up) Fix spelling

Description Nick Clemens (kidclamp) 2024-11-01 12:53:08 UTC
The test creates two users, and says list should return both, however, the user performing the call doesn't have 'view_borrower_infos_from_any_libraries' permission and only lists 1, which is what the test checks
Comment 1 Nick Clemens (kidclamp) 2024-11-01 12:54:27 UTC
Created attachment 173873 [details] [review]
Bug 38322: Adust tests
Comment 2 David Nind 2024-11-08 20:08:19 UTC
Created attachment 174297 [details] [review]
Bug 38322: Adjust tests

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-11-08 20:09:21 UTC
Tests pass before and after the patch: prove t/db_dependent/api/v1/erm_users.t
Comment 4 Martin Renvoize (ashimema) 2024-11-13 09:36:36 UTC
Created attachment 174450 [details] [review]
Bug 38322: Adjust tests

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2024-11-13 09:36:38 UTC
Created attachment 174451 [details] [review]
Bug 38322: (QA follow-up) Fix spelling

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Katrin Fischer 2024-11-13 16:02:20 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Lucas Gass (lukeg) 2024-12-05 22:27:26 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 8 David Nind 2024-12-16 02:36:23 UTC
I've added a release note, but I'm not sure that I have described what the problem was, and what was fixed.
Comment 9 Fridolin Somers 2024-12-18 13:21:15 UTC
Pushed to 23.11.x for 23.11.11
Comment 10 Jesse Maseto 2025-02-03 16:23:11 UTC
Not pushed to LTS. Marked Resolved.

If you feel this should be in LTS please reply with your reason.