| Summary: | Cannot delete ILL batch statuses | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Phil Ringnalda <phil> |
| Component: | System Administration | Assignee: | Phil Ringnalda <phil> |
| Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, lucas, martin.renvoize, sam.sowanick |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00,24.05.06
|
|
| Circulation function: | |||
| Bug Depends on: | 36192 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 38328: Cannot delete ILL batch statuses
Bug 38328: Cannot delete ILL batch statuses Bug 38328: Cannot delete ILL batch statuses |
||
|
Description
Phil Ringnalda
2024-11-01 18:15:26 UTC
Created attachment 173888 [details] [review] Bug 38328: Cannot delete ILL batch statuses You are permitted to delete ILL batch statuses that you (rather than the system) add, but the UI didn't get the CSRF memo about delete ops needing to be POSTs with op="cud-delete", so it still uses a GET of ?op="delete" and fails. Test plan: 1. Set the preference ILLModule to 'Enable' 2. Administration - Interlibrary loan batch statuses - New batch status 3. Give it a name, an uppercase code, and Save 4. Click the Delete button to the right of your new status 5. The page is blank, and if you navigate back to Interlibrary loan batch statuses, you'll see that yours was not deleted 6. Apply patch, reload page 7. Click the Delete button to the right of your new status, verify it is deleted Sponsored-by: Chetco Community Public Library Created attachment 174051 [details] [review] Bug 38328: Cannot delete ILL batch statuses You are permitted to delete ILL batch statuses that you (rather than the system) add, but the UI didn't get the CSRF memo about delete ops needing to be POSTs with op="cud-delete", so it still uses a GET of ?op="delete" and fails. Test plan: 1. Set the preference ILLModule to 'Enable' 2. Administration - Interlibrary loan batch statuses - New batch status 3. Give it a name, an uppercase code, and Save 4. Click the Delete button to the right of your new status 5. The page is blank, and if you navigate back to Interlibrary loan batch statuses, you'll see that yours was not deleted 6. Apply patch, reload page 7. Click the Delete button to the right of your new status, verify it is deleted Sponsored-by: Chetco Community Public Library Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Created attachment 174463 [details] [review] Bug 38328: Cannot delete ILL batch statuses You are permitted to delete ILL batch statuses that you (rather than the system) add, but the UI didn't get the CSRF memo about delete ops needing to be POSTs with op="cud-delete", so it still uses a GET of ?op="delete" and fails. Test plan: 1. Set the preference ILLModule to 'Enable' 2. Administration - Interlibrary loan batch statuses - New batch status 3. Give it a name, an uppercase code, and Save 4. Click the Delete button to the right of your new status 5. The page is blank, and if you navigate back to Interlibrary loan batch statuses, you'll see that yours was not deleted 6. Apply patch, reload page 7. Click the Delete button to the right of your new status, verify it is deleted Sponsored-by: Chetco Community Public Library Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 Not for 23.11.x No interface changes to document, just a bugfix. |