Summary: | Remove orphan confirm_deletion() in supplier.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Phil Ringnalda <phil> |
Component: | Acquisitions | Assignee: | Phil Ringnalda <phil> |
Status: | RESOLVED FIXED | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, jesse, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00,24.05.06,23.11.11
|
Circulation function: | |
Bug Depends on: | 28082 | ||
Bug Blocks: | |||
Attachments: |
Bug 38329: Remove orphan confirm_deletion() in supplier.tt
Bug 38329: Remove orphan confirm_deletion() in supplier.tt Bug 38329: Remove orphan confirm_deletion() in supplier.tt |
Description
Phil Ringnalda
2024-11-01 19:29:28 UTC
Created attachment 173890 [details] [review] Bug 38329: Remove orphan confirm_deletion() in supplier.tt The JavaScript function confirm_deletion() in supplier.tt has either been an unused orphan since bug 28082 two years ago, or since the switch from YUI to Bootstrap 12 years ago. Doesn't matter which, nothing calls it, and if it was called, it would fail by trying to GET with op="delete" rather than POST with op="cud-delete". Test plan: 1. Acquisitions - New vendor, enter a name and Save 2. Click the name of your new vendor, so your URL is at supplier.pl 3. Click Delete vendor to verify that deleting still works without this unused code which would fail Sponsored-by: Chetco Community Public Library Created attachment 173948 [details] [review] Bug 38329: Remove orphan confirm_deletion() in supplier.tt The JavaScript function confirm_deletion() in supplier.tt has either been an unused orphan since bug 28082 two years ago, or since the switch from YUI to Bootstrap 12 years ago. Doesn't matter which, nothing calls it, and if it was called, it would fail by trying to GET with op="delete" rather than POST with op="cud-delete". Test plan: 1. Acquisitions - New vendor, enter a name and Save 2. Click the name of your new vendor, so your URL is at supplier.pl 3. Click Delete vendor to verify that deleting still works without this unused code which would fail Sponsored-by: Chetco Community Public Library Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 174044 [details] [review] Bug 38329: Remove orphan confirm_deletion() in supplier.tt The JavaScript function confirm_deletion() in supplier.tt has either been an unused orphan since bug 28082 two years ago, or since the switch from YUI to Bootstrap 12 years ago. Doesn't matter which, nothing calls it, and if it was called, it would fail by trying to GET with op="delete" rather than POST with op="cud-delete". Test plan: 1. Acquisitions - New vendor, enter a name and Save 2. Click the name of your new vendor, so your URL is at supplier.pl 3. Click Delete vendor to verify that deleting still works without this unused code which would fail Sponsored-by: Chetco Community Public Library Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! BAckported to 24.05.x for upcoming 24.05.06 Pushed to 23.11.x for 23.11.11 Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. |