Bug 38344

Summary: Don't send "Thank you !" as screen message
Product: Koha Reporter: Magnus Enger <magnus>
Component: SIP2Assignee: David Nind <david>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: david, fridolin.somers, lucas
Version: MainKeywords: Academy, no-sandbox
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes a typo in a SIP output message - "Thank you !" should be "Thank you!" (note the space before the exclamation mark).
Version(s) released in:
24.11.00,24.05.06
Circulation function:
Attachments: Bug 38344: Fix typo - space before exclamation mark in "Thank you !"
Bug 38344: Fix typo - space before exclamation mark in "Thank you !"
Bug 38344: Fix typo - space before exclamation mark in "Thank you !"

Description Magnus Enger 2024-11-04 14:32:04 UTC
$ grep -rn "Thank you !" *
C4/SIP/ILS.pm:317:    return (1, 'Thank you !', '');

We should remove the space before the exclamation.
Comment 1 David Nind 2024-11-10 19:27:33 UTC
Created attachment 174317 [details] [review]
Bug 38344: Fix typo - space before exclamation mark in "Thank you !"

In English, there should not be a space before an exclamation mark
in a sentence. For example, "Thank you !" is not correct.

Test plan:
1. Search the codebase for "Thank you !": grep -rn "Thank you !" *
2. Result - one occurance:
   C4/SIP/ILS.pm:317:    return (1, 'Thank you !', '');
3. Apply the patch.
4. Repeat step 1.
5. There should now be no occurances.

Signed-off-by: David Nind <david@davidnind.com>
Comment 2 Phil Ringnalda 2024-11-14 02:30:34 UTC
Created attachment 174485 [details] [review]
Bug 38344: Fix typo - space before exclamation mark in "Thank you !"

In English, there should not be a space before an exclamation mark
in a sentence. For example, "Thank you !" is not correct.

Test plan:
1. Search the codebase for "Thank you !": grep -rn "Thank you !" *
2. Result - one occurance:
   C4/SIP/ILS.pm:317:    return (1, 'Thank you !', '');
3. Apply the patch.
4. Repeat step 1.
5. There should now be no occurances.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 David Nind 2024-11-14 19:22:43 UTC
Thanks for the sign-off Phil!
Comment 4 Chris Cormack 2024-11-14 20:00:37 UTC
Created attachment 174534 [details] [review]
Bug 38344: Fix typo - space before exclamation mark in "Thank you !"

In English, there should not be a space before an exclamation mark
in a sentence. For example, "Thank you !" is not correct.

Test plan:
1. Search the codebase for "Thank you !": grep -rn "Thank you !" *
2. Result - one occurance:
   C4/SIP/ILS.pm:317:    return (1, 'Thank you !', '');
3. Apply the patch.
4. Repeat step 1.
5. There should now be no occurances.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 5 Katrin Fischer 2024-11-19 15:36:52 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-12-05 22:39:50 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 7 Fridolin Somers 2024-12-18 13:22:44 UTC
I prefer not to backport since this string may be translated in SIPConfig.xml
Comment 8 David Nind 2024-12-18 19:24:58 UTC
This is a bug fix and no interface changes, no changes to the manual required.