Summary: | compare_es_to_db.pl shouldn't retrieve the records from ES | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Command-line Utilities | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | RESOLVED FIXED | QA Contact: | Nick Clemens (kidclamp) <nick> |
Severity: | minor | ||
Priority: | P5 - low | CC: | dcook, jonathan.druart, martin.renvoize, nick, paul.derscheid, robin, tomascohen, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This small enhancement makes the `compare_es_to_db.pl` maintenance script require less resources when run.
|
|
Version(s) released in: |
25.05.00,24.11.02
|
Circulation function: | |
Bug Depends on: | 22831 | ||
Bug Blocks: | |||
Attachments: |
Bug 38386: Make compare_es_to_db.pl not retrieve the records from ES
Bug 38386: Make compare_es_to_db.pl not retrieve the records from ES |
Description
Tomás Cohen Arazi (tcohen)
2024-11-07 11:13:59 UTC
Created attachment 174115 [details] [review] Bug 38386: Make compare_es_to_db.pl not retrieve the records from ES Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> in order to understand the difference in the behavior, you need an ES-enabled KTD: ```shell ktd --proxy --es7 up -d ktd --shell ``` Then compare the output of the following commands: ```shell curl -X GET 'http://es:9200/koha_kohadev_biblios/_search?scroll=1m&size=10' -H 'Content-Type: application/json' -d'{"query":{"match_all":{}}}' ``` and ```shell curl -X GET 'http://es:9200/koha_kohadev_biblios/_search?scroll=1m&size=10' -H 'Content-Type: application/json' -d'{"_source":false,"query":{"match_all":{}}}' ``` Created attachment 174583 [details] [review] Bug 38386: Make compare_es_to_db.pl not retrieve the records from ES Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Small change, big impact, passing QA Pushed for 25.05! Well done everyone, thank you! Moving from 'enhancement' to 'minor' - this is a performance bug really, and should be backported to make the tool more usable Nice work everyone! Pushed to 24.11.x for 24.11.02 Not backporting to 24.05.x unless requested I think this should be backported if possible. It can really stress too much the ES without it, and is really simple. |