Bug 38455

Summary: UNIMARC XSLT Music incipit (036) try to display field 031 (as in MARC21)
Product: Koha Reporter: Marion Durand <marion.durand>
Component: OPACAssignee: Marion Durand <marion.durand>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: e.betemps
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 22581    
Bug Blocks:    
Attachments: Bug 38455: UNIMARC XSLT diplay field 036 correctly
Bug 38455: UNIMARC XSLT diplay field 036 correctly

Description Marion Durand 2024-11-15 10:24:26 UTC
In file koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl the test to display information from field 031 (music incipit) is perform on field 036 (which is unrelated).
Comment 1 Marion Durand 2024-11-15 13:44:23 UTC
In file koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl the code to display the music incipit (field 036 in UNIAMARC) display field 031 (as in MARC21) despite testing for the existence of field 036.
Comment 2 Marion Durand 2024-12-19 15:18:33 UTC
Created attachment 175771 [details] [review]
Bug 38455: UNIMARC XSLT diplay field 036 correctly

In Unimarc, the field for music incipit is 036. The test to display the music player is correctly on field 036 but the field displayed was 031 (which is valid for Marc21 but not for Unimac).

To test:
On a Koha Unimarc instance:
1- Set system preference "OPACPlayMusicalInscripts" to "Play" and "OPACShowMusicalInscripts" to "Show"
2- set the system preference OPACXSLTListsDisplay is set on koha-tmpl/opac-tmpl/bootstrap/{languagecode}/xslt/UNIMARCslim2OPACDetail.xsl
3- Update a framework of your choice to display subfield 036$2 $g $n $o $p in OPAC, intranet and editor (make sure the collapse checkbox is not checked)
4- Create a record with the previously modified framework, fill all mandatory fields and add a 036 field with at least subfield $2 $g $n $o $p, make sure you have no 031 field
example of a valid 036 field
    036$2 pe
    036$g G-2
    036$n bB
    036$o 3/4
    036$p {8C'8C'}/4D4C'4F/2E
5- Go to the OPAC detail page for the record created (with interface in English)
6- check that the music player does not appear
7- apply the patch
8- Reload the OPAC detail page for the record created (sill with interface in English)
9- check that the music player appears and is working
Comment 3 Emmanuel Bétemps 2025-04-04 09:02:56 UTC
Created attachment 180617 [details] [review]
Bug 38455: UNIMARC XSLT diplay field 036 correctly

In Unimarc, the field for music incipit is 036. The test to display the music player is correctly on field 036 but the field displayed was 031 (which is valid for Marc21 but not for Unimac).

To test:
On a Koha Unimarc instance:
1- Set system preference "OPACPlayMusicalInscripts" to "Play" and "OPACShowMusicalInscripts" to "Show"
2- set the system preference OPACXSLTListsDisplay is set on koha-tmpl/opac-tmpl/bootstrap/{languagecode}/xslt/UNIMARCslim2OPACDetail.xsl
3- Update a framework of your choice to display subfield 036$2 $g $n $o $p in OPAC, intranet and editor (make sure the collapse checkbox is not checked)
4- Create a record with the previously modified framework, fill all mandatory fields and add a 036 field with at least subfield $2 $g $n $o $p, make sure you have no 031 field
example of a valid 036 field
    036$2 pe
    036$g G-2
    036$n bB
    036$o 3/4
    036$p {8C'8C'}/4D4C'4F/2E
5- Go to the OPAC detail page for the record created (with interface in English)
6- check that the music player does not appear
7- apply the patch
8- Reload the OPAC detail page for the record created (sill with interface in English)
9- check that the music player appears and is working

Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>