Summary: | Cannot cancel background job (CSRF) | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Architecture, internals, and plumbing | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | RESOLVED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, jonathan.druart, katrin.fischer, lucas, m.de.rooy, rcoert |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
24.11.00,24.05.06
|
Circulation function: | |
Bug Depends on: | 34478 | ||
Bug Blocks: | |||
Attachments: |
Bug 38495: Use JS to submit form to cancel background jobs
Bug 38495: Use JS to submit form to cancel background jobs Bug 38495: (follow-up) Add a confirmation message Bug 38495: Use JS to submit form to cancel background jobs Bug 38495: (follow-up) Add a confirmation message |
Description
Nick Clemens (kidclamp)
2024-11-20 13:23:54 UTC
Created attachment 174841 [details] [review] Bug 38495: Use JS to submit form to cancel background jobs This patch adjusts the link to cancel jobs to be submitted as a POST with cud-cancel operation To test: 1 - Stop your long tasks bacground jobs worker sudo koha-worker --stop --queue long_tasks kohadev 2 - Stage a file for import 3 - Administration -> Manage jobs 4 - See your new job 5 - Click 'cancel' 6 - It didn't work 7 - Apply patch 8 - Browse to jobs again 9 - Click 'Cancel' 10 - Job is successfully cancelled Created attachment 174842 [details] [review] Bug 38495: Use JS to submit form to cancel background jobs This patch adjusts the link to cancel jobs to be submitted as a POST with cud-cancel operation To test: 1 - Stop your long tasks bacground jobs worker sudo koha-worker --stop --queue long_tasks kohadev 2 - Stage a file for import 3 - Administration -> Manage jobs 4 - See your new job 5 - Click 'cancel' 6 - It didn't work 7 - Apply patch 8 - Browse to jobs again 9 - Click 'Cancel' 10 - Job is successfully cancelled Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> We are missing a confirmation box. Created attachment 174843 [details] [review] Bug 38495: (follow-up) Add a confirmation message Looking here Created attachment 174910 [details] [review] Bug 38495: Use JS to submit form to cancel background jobs This patch adjusts the link to cancel jobs to be submitted as a POST with cud-cancel operation To test: 1 - Stop your long tasks bacground jobs worker sudo koha-worker --stop --queue long_tasks kohadev 2 - Stage a file for import 3 - Administration -> Manage jobs 4 - See your new job 5 - Click 'cancel' 6 - It didn't work 7 - Apply patch 8 - Browse to jobs again 9 - Click 'Cancel' 10 - Job is successfully cancelled Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 174911 [details] [review] Bug 38495: (follow-up) Add a confirmation message Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT} Added a html filter for qa tools.. Moving to major to get RM attention for next release :) Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 Not for 23.11.x Internal architecture, nothing to add/edit in the manual. |