Bug 38495

Summary: Cannot cancel background job (CSRF)
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: Architecture, internals, and plumbingAssignee: Nick Clemens (kidclamp) <nick>
Status: Signed Off --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: jonathan.druart
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 34478    
Bug Blocks:    
Attachments: Bug 38495: Use JS to submit form to cancel background jobs
Bug 38495: Use JS to submit form to cancel background jobs
Bug 38495: (follow-up) Add a confirmation message

Description Nick Clemens (kidclamp) 2024-11-20 13:23:54 UTC
The operation to cancel a job needs to be cud-cancel and we need to submit as post
Comment 1 Nick Clemens (kidclamp) 2024-11-20 13:27:51 UTC
Created attachment 174841 [details] [review]
Bug 38495: Use JS to submit form to cancel background jobs

This patch adjusts the link to cancel jobs to be submitted as a POST with cud-cancel operation

To test:
1 - Stop your long tasks bacground jobs worker
   sudo koha-worker --stop --queue long_tasks kohadev
2 - Stage a file for import
3 - Administration -> Manage jobs
4 - See your new job
5 - Click 'cancel'
6 - It didn't work
7 - Apply patch
8 - Browse to jobs again
9 - Click 'Cancel'
10 - Job is successfully cancelled
Comment 2 Jonathan Druart 2024-11-20 13:43:44 UTC
Created attachment 174842 [details] [review]
Bug 38495: Use JS to submit form to cancel background jobs

This patch adjusts the link to cancel jobs to be submitted as a POST with cud-cancel operation

To test:
1 - Stop your long tasks bacground jobs worker
   sudo koha-worker --stop --queue long_tasks kohadev
2 - Stage a file for import
3 - Administration -> Manage jobs
4 - See your new job
5 - Click 'cancel'
6 - It didn't work
7 - Apply patch
8 - Browse to jobs again
9 - Click 'Cancel'
10 - Job is successfully cancelled

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2024-11-20 13:44:16 UTC
We are missing a confirmation box.
Comment 4 Nick Clemens (kidclamp) 2024-11-20 13:55:34 UTC
Created attachment 174843 [details] [review]
Bug 38495: (follow-up) Add a confirmation message