Description
Andrew Fuerste-Henry
2024-11-25 21:29:38 UTC
Created attachment 174992 [details] [review] Bug 38532: show both debits and credits in patron_messages To test: 1: Have patrons with a variety of credit/debit combinations 2: Confirm Koha shows the total debit amount in patron_messages if any debits exist 3: Confirm Koha does not show anything about creditd in patron_messages if any debits exist 4: Apply patch, restart_all 5: Confirm all patrons show both debit total and credit total To be a bit more clear, these changes are to the messages marked with Attention on the patron checkout (/cgi-bin/koha/circ/circulation.pl) and details (/cgi-bin/koha/members/moremember.pl) screens. Created attachment 181296 [details] [review] Bug 38532: show both debits and credits in patron_messages To test: 1: Have patrons with a variety of credit/debit combinations 2: Confirm Koha shows the total debit amount in patron_messages if any debits exist 3: Confirm Koha does not show anything about creditd in patron_messages if any debits exist 4: Apply patch, restart_all 5: Confirm all patrons show both debit total and credit total Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Created attachment 181297 [details] [review] Bug 38532: (follow-up) Use Koha::Patron->account methods Update the patch to use Koha::Account and it's associated 'outstanding' methods to ensure we accurately portray outstanding amounts rather than 'all credits' totals. I also remove the unused `$balance` variable from the members/moremember.pl controller. Created attachment 181298 [details] [review] Bug 38532: (follow-up) Use Koha::Patron->account methods Update the patch to use Koha::Account and it's associated 'outstanding' methods to ensure we accurately portray outstanding amounts rather than 'all credits' totals. I also remove the unused `$balance` variable from the members/moremember.pl controller. You'll want to ensure AccountAutoReconcile is set to not reconcile to test these and ensure partial application of some credits against debts.. that way you'll get an accurate test of all combinations. Created attachment 181562 [details] [review] Bug 38532: Show both debits and credits on patron's check out and details pages To test: 1: Have patrons with a variety of credit/debit combinations 2: Confirm Koha shows the total debit amount in patron_messages if any debits exist 3: Confirm Koha does not show anything about creditd in patron_messages if any debits exist 4: Apply patch, restart_all 5: Confirm all patrons show both debit total and credit total Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: David Nind <david@davidnind.com> Created attachment 181563 [details] [review] Bug 38532: (follow-up) Use Koha::Patron->account methods Update the patch to use Koha::Account and it's associated 'outstanding' methods to ensure we accurately portray outstanding amounts rather than 'all credits' totals. I also remove the unused `$balance` variable from the members/moremember.pl controller. Signed-off-by: David Nind <david@davidnind.com> I edited the title of the first commit message. How I tested (using KTD): 1. Used Mary Burton as the patron. 2. Added some manual debits and credits: - Manual invoice 1: $5.00 - Manual invoice 2: $5.00 - Manual credit 1: $15.00 - Manual credit 2: $15.00 3. If you look at the patron's check out and details pages, they only show the total charges ($10 in this case): ==> Charges: Patron has outstanding charges of 10.00. 4. Apply the patches. 5. Re-check the pages, they now show: ==> Charges: Patron has outstanding charges of 10.00. Credits: Patron has outstanding creditsof 35.00 I'll add a follow-up to add a space for the credits message. Created attachment 181564 [details] [review] Bug 38532: (follow-up) Add missing space for credits message Fix credit message to add a missing space: - Previously: Credits: Patron has outstanding creditsof - Now: Credits: Patron has outstanding credits of Signed-off-by: David Nind <david@davidnind.com> Nice one David, thanks for the thorough testing and follow-up. Created attachment 182011 [details] [review] Bug 38532: Show both debits and credits on patron's check out and details pages To test: 1: Have patrons with a variety of credit/debit combinations 2: Confirm Koha shows the total debit amount in patron_messages if any debits exist 3: Confirm Koha does not show anything about creditd in patron_messages if any debits exist 4: Apply patch, restart_all 5: Confirm all patrons show both debit total and credit total Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Created attachment 182012 [details] [review] Bug 38532: (follow-up) Use Koha::Patron->account methods Update the patch to use Koha::Account and it's associated 'outstanding' methods to ensure we accurately portray outstanding amounts rather than 'all credits' totals. I also remove the unused `$balance` variable from the members/moremember.pl controller. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> Created attachment 182013 [details] [review] Bug 38532: (follow-up) Add missing space for credits message Fix credit message to add a missing space: - Previously: Credits: Patron has outstanding creditsof - Now: Credits: Patron has outstanding credits of Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> (In reply to David Nind from comment #10) > Created attachment 181564 [details] [review] [review] > Bug 38532: (follow-up) Add missing space for credits message > > Fix credit message to add a missing space: > - Previously: Credits: Patron has outstanding creditsof > - Now: Credits: Patron has outstanding credits of > > Signed-off-by: David Nind <david@davidnind.com> Oh.. this is an odd one.. the tidy script nukes the space.. I've reworked your patch to add the space before the template toolkit condition and that appeases the QA script and tidy... little odd though.. I'll raise it with Jonathan. (In reply to Martin Renvoize (ashimema) from comment #15) > (In reply to David Nind from comment #10) > > Created attachment 181564 [details] [review] [review] [review] > > Bug 38532: (follow-up) Add missing space for credits message > > > > Fix credit message to add a missing space: > > - Previously: Credits: Patron has outstanding creditsof > > - Now: Credits: Patron has outstanding credits of > > > > Signed-off-by: David Nind <david@davidnind.com> > > Oh.. this is an odd one.. the tidy script nukes the space.. I've reworked > your patch to add the space before the template toolkit condition and that > appeases the QA script and tidy... little odd though.. I'll raise it with > Jonathan. THanks Martin! Pushed for 25.05! Well done everyone, thank you! |