Bug 38544

Summary:	OPAC modal login should not exist when OPAC login is disabled
Product:	Koha	Reporter:	Fridolin Somers <fridolin.somers>
Component:	OPAC	Assignee:	Fridolin Somers <fridolin.somers>
Status:	Pushed to main ---	QA Contact:	Matt Blenkinsop <matt.blenkinsop>
Severity:	normal
Priority:	P5 - low	CC:	dcook, matt.blenkinsop
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	25.05.00
Circulation function:
Attachments:	Bug 38544: OPAC Modal login not generated when OPAC login is disabled Bug 38544: OPAC Modal login not generated when OPAC login is disabled Bug 38544: OPAC Modal login not generated when OPAC login is disabled

Description Fridolin Somers 2024-11-27 09:48:37 UTC

When OPAC auth is disabled (system preference opacuserlogin),
the modal auth should not exist in HTML.

The access to opac-user.pl shows a message and not auth form.
But this has been detected by a security check.
So better not have this form in modal.

Looks like it is missing :
[% IF ( Koha.Preference( 'opacuserlogin' ) == 1 ) %]

Comment 1 Fridolin Somers 2024-11-27 10:02:50 UTC

Created attachment 175002 [details] [review]
Bug 38544: OPAC Modal login not generated when OPAC login is disabled

When OPAC login is disabled (system preference opacuserlogin),
the modal login should not exist in HTML.

Note the access to opac-user.pl shows a message and not auth form.

You may look at commit with : git diff --ignore-space-change

Test plan :
1.1) Set system preference opacuserlogin to "Allow"
1.2) Go to OPAC main page
1.3) Check you see in source : div id="loginModal"
1.4) Click on "Log in to your account"
1.5) Check you see the modal login
2.1) Set system preference opacuserlogin to "Don't allow"
2.2) Go to OPAC main page
2.3) Check you do not see in source : div id="loginModal"

Comment 2 David Cook 2024-11-27 22:16:25 UTC

Created attachment 175014 [details] [review]
Bug 38544: OPAC Modal login not generated when OPAC login is disabled

When OPAC login is disabled (system preference opacuserlogin),
the modal login should not exist in HTML.

Note the access to opac-user.pl shows a message and not auth form.

You may look at commit with : git diff --ignore-space-change

Test plan :
1.1) Set system preference opacuserlogin to "Allow"
1.2) Go to OPAC main page
1.3) Check you see in source : div id="loginModal"
1.4) Click on "Log in to your account"
1.5) Check you see the modal login
2.1) Set system preference opacuserlogin to "Don't allow"
2.2) Go to OPAC main page
2.3) Check you do not see in source : div id="loginModal"

Signed-off-by: David Cook <dcook@prosentient.com.au>

Comment 3 David Cook 2024-11-27 22:17:39 UTC

While the "Splinter Review" looks scary, if you do a "git show -w", you'll see it really is just a very simple 2-3 line change, which does exactly what it says it's going to do.

Comment 4 David Cook 2024-11-27 22:18:22 UTC

And if I'd actually read the commit message, I would've seen that Frido already suggested something like that haha.

Comment 5 Fridolin Somers 2024-11-29 09:38:46 UTC

(In reply to David Cook from comment #4)
> And if I'd actually read the commit message, I would've seen that Frido
> already suggested something like that haha.

Great it helped ;)

Comment 6 Matt Blenkinsop 2024-12-09 11:15:47 UTC

Created attachment 175295 [details] [review]
Bug 38544: OPAC Modal login not generated when OPAC login is disabled

When OPAC login is disabled (system preference opacuserlogin),
the modal login should not exist in HTML.

Note the access to opac-user.pl shows a message and not auth form.

You may look at commit with : git diff --ignore-space-change

Test plan :
1.1) Set system preference opacuserlogin to "Allow"
1.2) Go to OPAC main page
1.3) Check you see in source : div id="loginModal"
1.4) Click on "Log in to your account"
1.5) Check you see the modal login
2.1) Set system preference opacuserlogin to "Don't allow"
2.2) Go to OPAC main page
2.3) Check you do not see in source : div id="loginModal"

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Comment 7 Katrin Fischer 2024-12-23 08:38:23 UTC

Pushed for 25.05!

Well done everyone, thank you!