Bug 38635

Summary: Improve place hold confirmation page in the OPAC
Product: Koha Reporter: Owen Leonard <oleonard>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: Needs Signoff --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Screenshot of the current hold confirmation screen
Proposed new interface
Bug 38635: Improve place hold confirmation page in the OPAC

Description Owen Leonard 2024-12-05 15:03:12 UTC
Created attachment 175244 [details]
Screenshot of the current hold confirmation screen

I think the current design of the OPAC's hold confirmation page is a little confusing, or at least cluttered. We have the heading "Placing a hold" and then a redundant (at least for sighted users) "Place a hold on" label next to the checkbox. I think we can clean it up a little.
Comment 1 Owen Leonard 2024-12-05 15:13:38 UTC
Created attachment 175247 [details]
Proposed new interface
Comment 2 Owen Leonard 2024-12-05 17:02:18 UTC
Created attachment 175251 [details] [review]
Bug 38635: Improve place hold confirmation page in the OPAC

This patch makes some markup and style changes to the hold confirmation
page in the OPAC with the intention of making the interface clearer and
less cluttered.

The "Place hold on" label for each title's checkbox has been hidden from
sighted users and visually grouped with the title information. The
checkbox itself is now hidden if only 1 hold is being placed.

The title is now a <legend> inside a <fieldset> in order to take
advantage of the fact that when fieldset has a "disabled" property the
form controls contained within are all disabled.

When placing multiple holds at once, unchecking the checkbox next to a
title will disable that title's form fields and give it a "disabled"
appearance.

Some Bootstrap grid markup has been added in order to improve the page's
responsive behavior. This update includes some indentation changes, so
ignore whitespace when viewing the diff.

Unrelated: Incorrect classes have been fixed on a few alerts. Also, CSS
related to a long-removed 3rd party service "iDreamBooks" has been
removed.

To test, apply the patch and rebuild the OPAC CSS.

- Log in to the OPAC as a user who can place holds.
- Perform a catalog search which will return multiple results.
- Next to one of those results, find a title which can be placed on
  hold and click the "Place hold" link.
  - On the hold confirmation page you should see the title of your hold
    and the standard controls. There should be no checkbox next to the
    title.
- Return to the search results page and check the checkbox for at
  least two items which are available to be place on hold. Click the
  "Place hold" button in the search results toolbar.
  - On the hold confirmation page you should see the titles you
    selected, each with a checkbox next to the title.
    - Uncheck one of the checkboxes. The details for that title should
      switch to "disabled" appearance. You should be unable to change
      the pickup location or click the "Show more options" link.
    - Re-check the checkbox and click the "Show more options" link to
      expand more fields.
    - Uncheck the checkbox again. The expanded section should collapse.
- Confirm that single and multiple holds are placed correctly. Test with
  various additional settings like expiration date or specific item to
  confirm that these options still work.

Sponsored-by: Athens County Public Libraries