Summary: | Searching for a patron from additem.pl triggers an issue slip to print | ||
---|---|---|---|
Product: | Koha | Reporter: | Brendan Lawlor <blawlor> |
Component: | Circulation | Assignee: | Brendan Lawlor <blawlor> |
Status: | Pushed to main --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | minor | ||
Priority: | P5 - low | CC: | alexbuckley, david, gmcharlt, jonathan.druart, kyle.m.hall, martin.renvoize |
Version: | Main | Keywords: | additional_work_needed |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes an issue when searching for a patron using the check out menu item in the header, when you are on the add or edit item form for a record. It was triggering a blank issue slip for printing. This was caused by a change in Bug 37407 (Fast add/fast cataloging from patron checkout does not checkout item) that affected checking referrer URLs and query strings.
|
Version(s) released in: |
25.05.00
|
Circulation function: | |||
Bug Depends on: | 37407 | ||
Bug Blocks: | |||
Attachments: |
Bug 38649: Fix autocheckout for circulation Fast Add only
Bug 38649: Fix autocheckout for circulation Fast Add only Bug 38649: Fix autocheckout for circulation Fast Add only |
Description
Brendan Lawlor
2024-12-06 17:46:50 UTC
Created attachment 175269 [details] [review] Bug 38649: Fix autocheckout for circulation Fast Add only In addition to checking the referrer for the URL domain and path we should also check the query string of the referrer to make sure it was from a circulation fast add. It should include frameworkcode=FA&circborrowernumber To test: 1. From anywhere on the additem.pl page where you are adding or editing an item 2. Click on Checkout in the menu bar and enter a patron's barcode 3. When circulation.pl loads it triggers a blank issue slip to be printed 4. Apply patch and repeat steps 1-3, no slip is triggered to print 5. Go to Circulation Checkout for a patron and enter a non existing barcode like 1337 6. Click '+ Add record using fast cataloging' 7. Fill in required fields and click 'Add item' 8. Confirm the item is auto checked out Created attachment 175275 [details] [review] Bug 38649: Fix autocheckout for circulation Fast Add only In addition to checking the referrer for the URL domain and path we should also check the query string of the referrer to make sure it was from a circulation fast add. It should include frameworkcode=FA&circborrowernumber To test: 1. From anywhere on the additem.pl page where you are adding or editing an item 2. Click on Checkout in the menu bar and enter a patron's barcode 3. When circulation.pl loads it triggers a blank issue slip to be printed 4. Apply patch and repeat steps 1-3, no slip is triggered to print 5. Go to Circulation Checkout for a patron and enter a non existing barcode like 1337 6. Click '+ Add record using fast cataloging' 7. Fill in required fields and click 'Add item' 8. Confirm the item is auto checked out Signed-off-by: David Nind <david@davidnind.com> Changed assignee 8-). I've attempted a release note, but not sure that I have got this right - I don't know how to describe it correctly for library staff. Created attachment 175595 [details] [review] Bug 38649: Fix autocheckout for circulation Fast Add only In addition to checking the referrer for the URL domain and path we should also check the query string of the referrer to make sure it was from a circulation fast add. It should include frameworkcode=FA&circborrowernumber To test: 1. From anywhere on the additem.pl page where you are adding or editing an item 2. Click on Checkout in the menu bar and enter a patron's barcode 3. When circulation.pl loads it triggers a blank issue slip to be printed 4. Apply patch and repeat steps 1-3, no slip is triggered to print 5. Go to Circulation Checkout for a patron and enter a non existing barcode like 1337 6. Click '+ Add record using fast cataloging' 7. Fill in required fields and click 'Add item' 8. Confirm the item is auto checked out Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Pushed for 25.05! Well done everyone, thank you! It produces a JS error: Uncaught TypeError: document.referrer.split(...)[1] is undefined On the following page: http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=51 not backporting to 24.05.x unless requested - keyword of additional work needed |