Summary: | HTML1 no longer valid? TT tags can be present in HTML without breaking the translator tool | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, victor |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38900 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 38714 | ||
Attachments: | Bug 38720: HTML1 no longer valid - remove xt/tt_valid.t |
Description
Jonathan Druart
2024-12-17 08:47:08 UTC
> What am I missing here? Did we finally fix this long-standing problem without knowing it? Either that or it was only valid with HTML::Template Because that's how old that guideline is: https://web.archive.org/web/20060902045435/Http://www.kohadocs.org/codingguidelines.html https://wiki.koha-community.org/w/index.php?title=Coding_Guidelines&oldid=473 It was updated for the switch to TT https://wiki.koha-community.org/w/index.php?title=Coding_Guidelines&type=revision&diff=6700&oldid=6210 So maybe it was still a valid issue that got fixed years later with a fix for something else in the translation script. Or it wasn't actually valid anymore but it was assumed to be. ---- Anyway, I guess you can use it safely for bug 38664 if you see that it doesn't create broken strings. If after your work there and your failed attempts to break things here, HTML1 could safely be obsoleted if nothing comes up. Found one problem so far: <li [% IF loop.count > 5 && !facet.active %]class="collapsible-facet" style="display:none"[% END %]> It breaks because of the '>' in the TT condition. Created attachment 177062 [details] [review] Bug 38720: HTML1 no longer valid - remove xt/tt_valid.t (In reply to Jonathan Druart from comment #2) > Found one problem so far: > > <li [% IF loop.count > 5 && !facet.active %]class="collapsible-facet" > style="display:none"[% END %]> > > It breaks because of the '>' in the TT condition. We might need to reintroduce the test with an adjustment to catch that, but it's for later. |