Bug 38762

Summary: compare_es_to_db.pl should provide links to the staff interface
Product: Koha Reporter: Tomás Cohen Arazi (tcohen) <tomascohen>
Component: Command-line UtilitiesAssignee: Tomás Cohen Arazi (tcohen) <tomascohen>
Status: Passed QA --- QA Contact: Jonathan Druart <jonathan.druart>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, lucas, nick, robin, tomascohen
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 22831    
Bug Blocks:    
Attachments: Bug 38762: Make compare_es_to_db.pl provide links to staff interface
Bug 38762: Make compare_es_to_db.pl provide links to staff interface
Bug 38762: Make compare_es_to_db.pl provide links to staff interface

Description Tomás Cohen Arazi (tcohen) 2024-12-20 13:03:04 UTC
The script currently generates a link to the OPAC URLs for the affected records. 

It should generate links we can copy and paste to access the records for fixing them.
Comment 1 Tomás Cohen Arazi (tcohen) 2024-12-20 13:13:14 UTC
Created attachment 175839 [details] [review]
Bug 38762: Make compare_es_to_db.pl provide links to staff interface

This patch makes the script provide links to the staff interface instead
of the OPAC. This way, the links can just be picked to access the
problematic records for fixing them.

To test:
1. Run:
   $ ktd --shell
  k$ perl misc/maintenance/compare_es_to_db.pl
=> FAIL: Generated links point to the OPAC
2. Apply this patch
3. Repeat 1
=> SUCCESS: Generated links are useful as they point to the staff
interface
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 2 Roman Dolny 2024-12-20 13:52:04 UTC
Created attachment 175845 [details] [review]
Bug 38762: Make compare_es_to_db.pl provide links to staff interface

This patch makes the script provide links to the staff interface instead
of the OPAC. This way, the links can just be picked to access the
problematic records for fixing them.

To test:
1. Run:
   $ ktd --shell
  k$ perl misc/maintenance/compare_es_to_db.pl
=> FAIL: Generated links point to the OPAC
2. Apply this patch
3. Repeat 1
=> SUCCESS: Generated links are useful as they point to the staff
interface
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Jonathan Druart 2025-01-16 13:42:46 UTC
Nick, do you agree with replacing the OPAC link with a staff interface link?
Comment 4 Lucas Gass (lukeg) 2025-01-29 15:55:21 UTC
(In reply to Jonathan Druart from comment #3)
> Nick, do you agree with replacing the OPAC link with a staff interface link?

Not Nick, but I do agree. It should point to the staff interface so staff can go fix it, I think. 

Also, I can't see patrons needing to ever view this.
Comment 5 Jonathan Druart 2025-01-30 08:30:10 UTC
Created attachment 177340 [details] [review]
Bug 38762: Make compare_es_to_db.pl provide links to staff interface

This patch makes the script provide links to the staff interface instead
of the OPAC. This way, the links can just be picked to access the
problematic records for fixing them.

To test:
1. Run:
   $ ktd --shell
  k$ perl misc/maintenance/compare_es_to_db.pl
=> FAIL: Generated links point to the OPAC
2. Apply this patch
3. Repeat 1
=> SUCCESS: Generated links are useful as they point to the staff
interface
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Jonathan Druart 2025-01-30 08:30:22 UTC
When did we pick those colours?? https://snipboard.io/wUmV50.jpg