Summary: | Typo 'minPasswordPreference' system preference | ||
---|---|---|---|
Product: | Koha | Reporter: | Roman Dolny <roman.dolny> |
Component: | Patrons | Assignee: | Roman Dolny <roman.dolny> |
Status: | Pushed to oldoldstable --- | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, kyle.m.hall, wainuiwitikapark |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes a typo in the code for OPAC password recovery - 'minPasswordPreference' to 'minPasswordLength' (the correct system preference name). It has no noticeable effect on resetting an account password from the OPAC.
|
|
Version(s) released in: |
25.05.00,24.11.03,24.05.09,23.11.14
|
Circulation function: | |
Attachments: |
Bug 38772: Typo 'minPasswordPreference' system preference
Bug 38772: Typo 'minPasswordPreference' system preference |
Description
Roman Dolny
2024-12-23 09:52:40 UTC
Created attachment 175909 [details] [review] Bug 38772: Typo 'minPasswordPreference' system preference Typo in system preference 'minPasswordPreference' -> 'minPasswordLength' in opac/opac-password-recovery.pl There is no 'minPasswordPreference' system preference in database. Bug 23816 added the capability to override minPasswordLength. Test plan: ========== 1. Check 'minPasswordPreference' appearances: git grep -i 'minPasswordPreference' **/* --> Note: only one in opac-password-recovery.pl; no one in sysprefs.sql 2. Apply the patch. 3. Repeat p. 1. Note there is not 'minPasswordPreference' at all. Created attachment 175920 [details] [review] Bug 38772: Typo 'minPasswordPreference' system preference Typo in system preference 'minPasswordPreference' -> 'minPasswordLength' in opac/opac-password-recovery.pl There is no 'minPasswordPreference' system preference in database. Bug 23816 added the capability to override minPasswordLength. Test plan: ========== 1. Check 'minPasswordPreference' appearances: git grep -i 'minPasswordPreference' **/* --> Note: only one in opac-password-recovery.pl; no one in sysprefs.sql 2. Apply the patch. 3. Repeat p. 1. Note there is not 'minPasswordPreference' at all. Signed-off-by: David Nind <david@davidnind.com> I've signed off, as it does appear to be a typo, and there is no minPasswordPreference system preference. However, this change makes no difference in actually resetting your password. Question for QA: So is this code still required/redundant/something else going on? I tested the OPAC password recovery process before and after applying the patch, and it worked as expected. I'm not a developer, so I have no idea how the underlying code works! Testing notes (KTD): 1. In the staff interface, check that the minPasswordPreference system preference DOES NOT exist. 2. In the staff interface, check that minPasswordLength system preference DOES exist (default is set to 8). 3. Set OpacResetPassword system preference to "Allow". 4. Set up KTD so that you can send emails [1]. 5. Add an email address to a patron, and change their credentials/password so that you can log in to the OPAC as that patron. 6. In the OPAC (logged out), select the "Forgot your password?" link, enter card number/user name, or email address. 7. Use the link in the email to reset the password. 8. Note that if the password length is less than the minimum length (before and after the patch), you can't reset your password unless it meets the minimum length. [1]. To test sending emails using a Google account: 1. Set up an App password for your Google Account. 2. Configure a new 'SMTP Server' under 'Administration > SMTP servers' using the following settings, where `User name` = your Google email address and `Password` = your APP password, not your Google account password): Host: smtp.gmail.com Port: 587 Timeout: 5 SSL: STARTTLS User name: GOOGLEACCOUNTUSER Password: GOOGLEAPPPASSWORD Debug mode: Enabled Default server: selected QA by RM. Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.03 Applied to 24.05.x for 24.05.09 Pushed to 23.11.x for 23.11.14 |