Summary: | SMTP server is not showing on the library detail page | ||
---|---|---|---|
Product: | Koha | Reporter: | Marion Durand <marion.durand> |
Component: | Staff interface | Assignee: | Owen Leonard <oleonard> |
Status: | Pushed to main --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | minor | ||
Priority: | P5 - low | CC: | bosse, david, gmcharlt, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the library detail page (Administration > Libraries > [view a library]) so that the SMTP server information is now shown (where it exists). Previously, the SMTP server was showing in the list of libraries, but not on the library's individual detail page.
|
|
Version(s) released in: |
25.05.00
|
Circulation function: | |
Attachments: |
Bug 38773: SMTP server is not showing on the library detail page
0001-Bug-38773-SMTP-server-is-not-showing-on-the-library Bug 38773: SMTP server is not showing on the library detail Bug 38773: SMTP server is not showing on the library detail page Bug 38773: SMTP server is not showing on the library detail page |
Description
Marion Durand
2024-12-23 11:14:12 UTC
Hello, The SMTP server isn't displaying because the template variable smtp_server isn't correctly referencing the associated SMTP server object. Should be an easy fix :) Created attachment 177360 [details] [review] Bug 38773: SMTP server is not showing on the library detail page This patch fixes and incorrect template variable name, making it possible to see a library's SMTP server when viewing the details of an individual library. Test plan copied from the original bug report: 1. Create an SMTP server in Koha (it doesn't need to be valid) a. Go to Administration -> Additional parameters -> SMTP servers b. Click "New STP server" c. Fill all mandatory fields (it doesn't need to be valid information) d. Click "Submit" 2. Add the created SMTP server to a library a. Go to Administration -> Basic parameters -> Libraries b. Choose a library and click on Edit (in column "Actions") c. On the line "SMTP server" select the server created d. Click "Submit" 3. Check the display a. Go to Administration -> Basic parameters -> Libraries b. Check that the name of the SMTP server you just selected is displayed in the column SMTP server c. Click on the name of the library you modified d. Check that the line "SMTP server" shows the correct information. 4. Test with different permissions a. If the logged-in user has both 'manage_libraries' and 'manage_smtp_servers' permissions the SMTP server name should be liked to the edit form for that server. b. If the logged-in user has only 'manage_libraries' permission there should be no link. Created attachment 177361 [details]
0001-Bug-38773-SMTP-server-is-not-showing-on-the-library
Hi Bosse, can you please re-attach your signed-off patch? If you are not using git-bz the comand would me something like: git format-patch origin If you are using git-bz, which we recommend, you can do this with: git-bz attach 38773 HEAD^.. the application/mbox format attached cannot be processed by our tools. Created attachment 177393 [details] Bug 38773: SMTP server is not showing on the library detail Sorry, I ran this command according to the wiki: git format-patch -s origin/main (In reply to Bosse from comment #5) > Created attachment 177393 [details] > Bug 38773: SMTP server is not showing on the library detail > > Sorry, I ran this command according to the wiki: > > git format-patch -s origin/main OK, maybe it's in how you attached the patch. We expect a file in .patch format as a result. Created attachment 177394 [details] [review] Bug 38773: SMTP server is not showing on the library detail page I think we now stepped on each others toes, but result looks good! Found the error. I wasn't marking it as a "patch" in bugzilla. Sorry and thanks:) Please don't forge to switch the status to "Signed off" - leaving it to you since the change gets counted for the dashboard :) Yes, sorry and thanks for the help! Created attachment 177399 [details] [review] Bug 38773: SMTP server is not showing on the library detail page This patch fixes and incorrect template variable name, making it possible to see a library's SMTP server when viewing the details of an individual library. Test plan copied from the original bug report: 1. Create an SMTP server in Koha (it doesn't need to be valid) a. Go to Administration -> Additional parameters -> SMTP servers b. Click "New STP server" c. Fill all mandatory fields (it doesn't need to be valid information) d. Click "Submit" 2. Add the created SMTP server to a library a. Go to Administration -> Basic parameters -> Libraries b. Choose a library and click on Edit (in column "Actions") c. On the line "SMTP server" select the server created d. Click "Submit" 3. Check the display a. Go to Administration -> Basic parameters -> Libraries b. Check that the name of the SMTP server you just selected is displayed in the column SMTP server c. Click on the name of the library you modified d. Check that the line "SMTP server" shows the correct information. 4. Test with different permissions a. If the logged-in user has both 'manage_libraries' and 'manage_smtp_servers' permissions the SMTP server name should be liked to the edit form for that server. b. If the logged-in user has only 'manage_libraries' permission there should be no link. Signed-off-by: Bo Gustavsson <bosse@gustavsson.one> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> (In reply to Bosse from comment #11) > Yes, sorry and thanks for the help! You are very welcome! Pushed for 25.05! Well done everyone, thank you! |