Bug 38778

Summary: Allow for custom sort order in holdshistory table
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: PatronsAssignee: Lucas Gass (lukeg) <lucas>
Status: Failed QA --- QA Contact: Pedro Amorim <pedro.amorim>
Severity: enhancement    
Priority: P5 - low CC: baptiste.wojtkowski, david, felicie.thiery, gmcharlt, kebliss, kyle, pedro.amorim
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
This enhancement adds the "Default sort order" option to the patron's holds history table in the staff interface. (Set at Koha administration > Additional parameters > Table settings > Patrons > holdshistory.)
Version(s) released in:
Circulation function:
Attachments: Bug 38778: Add default_sort_order to holdshistory table
Bug 38778: Add default_sort_order to holdshistory table
Bug 38778: Add default_sort_order to holdshistory table
Bug 38778: Add default_sort_order to holdshistory table

Description Lucas Gass (lukeg) 2024-12-23 18:14:33 UTC
Holds history defaults to a sort of 'Library', some would find to useful to have a different sort order for this table.
Comment 1 Lucas Gass (lukeg) 2024-12-23 18:17:42 UTC
Created attachment 175914 [details] [review]
Bug 38778: Add default_sort_order to holdshistory table

To test:
1. APPLY PATCH, restart_all
2. If you are saving the configuration state you need to clear cookies/cache
3. To go Table settings, find the holdshistory table
4. Try applying some different "Default sort order:"
5. Find a patron with a holds history and make sure the default sort order is working
Comment 2 ByWater Sandboxes 2025-01-09 20:25:07 UTC
Created attachment 176303 [details] [review]
Bug 38778: Add default_sort_order to holdshistory table

To test:
1. APPLY PATCH, restart_all
2. If you are saving the configuration state you need to clear cookies/cache
3. To go Table settings, find the holdshistory table
4. Try applying some different "Default sort order:"
5. Find a patron with a holds history and make sure the default sort order is working

Signed-off-by: William Lavoie <william.lavoie@inLibro.com>
Comment 3 Lucas Gass (lukeg) 2025-06-27 17:12:52 UTC
Created attachment 183616 [details] [review]
Bug 38778: Add default_sort_order to holdshistory table

To test:
1. APPLY PATCH, restart_all
2. If you are saving the configuration state you need to clear cookies/cache
3. To go Table settings, find the holdshistory table
4. Try applying some different "Default sort order:"
5. Find a patron with a holds history and make sure the default sort order is working

NOTE: If "Save configuration state on page change:" is on for this table you might want to turn it off for testing this bug.
Comment 4 David Nind 2025-06-29 19:56:40 UTC
Created attachment 183634 [details] [review]
Bug 38778: Add default_sort_order to holdshistory table

To test:
1. APPLY PATCH, restart_all
2. If you are saving the configuration state you need to clear cookies/cache
3. To go Table settings, find the holdshistory table
4. Try applying some different "Default sort order:"
5. Find a patron with a holds history and make sure the default sort order is working

NOTE: If "Save configuration state on page change:" is on for this table you might want to turn it off for testing this bug.
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Pedro Amorim 2025-08-05 14:37:23 UTC
I believe default_sort_order should be 4 now. 3 is the itemcallnumber.

Testing notes:
1) Use a new incognito window to quickly work around cookies/cache.
2) Place holds for 'koha' user and visit the table in question at:
<staff_url>/cgi-bin/koha/members/holdshistory.pl?borrowernumber=51