Description
Caroline Cyr La Rose
2025-01-14 17:32:18 UTC
Il also blocks update_patrons_category.pl from completing the change of category We also noticed that this causes problems when a guarantee changes category using the script update_patrons_category.pl and is now in the same category as their guarantor. Created attachment 176585 [details] [review] Bug 38892: Show correct error message when we attempt to add guarantor as a child When we attempt to add child as guarantor the error message shown is 'A guarantor cannot be a guarantee.' it doesn't make sense To recreate: 1. Go to Patrons 2. Click 'New patron' > 'Kid' 3. Fill out surname and cardnumber 4. Under Patron guarantor, click Add guarantor 5. Search for category = Kid and choose one of the patrons 6. Choose the relationship 7. Click 'Save' --> Error A guarantor cannot be a guarantee. 8. Apply the patch 9. repeat previous steps 10. After clicking Save --> the error message shown is «Child patron cannot be a guarantor.» Created attachment 177134 [details] [review] Bug 38892: Show correct error message when we attempt to add guarantor as a child When we attempt to add child as guarantor the error message shown is 'A guarantor cannot be a guarantee.' it doesn't make sense To recreate: 1. Go to Patrons 2. Click 'New patron' > 'Kid' 3. Fill out surname and cardnumber 4. Under Patron guarantor, click Add guarantor 5. Search for category = Kid and choose one of the patrons 6. Choose the relationship 7. Click 'Save' --> Error A guarantor cannot be a guarantee. 8. Apply the patch 9. repeat previous steps 10. After clicking Save --> the error message shown is «Child patron cannot be a guarantor.» Signed-off-by: David Nind <david@davidnind.com> I've tested, things work as per the test plan, so I've signed off. However, I'm a bit confused with this, reflecting that this area has gotten complicated! Are we saying: - At the moment (even after bug 37892), a patron can't be a guarantor for a patron in the same patron category - and that they should be able to be? - Or that they should be able to be a guarantor, as long as the patron category is not a "Category type" of "Child"? Created attachment 177628 [details] [review] Bug 38892: Show correct error message when we attempt to add guarantor as a child When we attempt to add child as guarantor the error message shown is 'A guarantor cannot be a guarantee.' it doesn't make sense To recreate: 1. Go to Patrons 2. Click 'New patron' > 'Kid' 3. Fill out surname and cardnumber 4. Under Patron guarantor, click Add guarantor 5. Search for category = Kid and choose one of the patrons 6. Choose the relationship 7. Click 'Save' --> Error A guarantor cannot be a guarantee. 8. Apply the patch 9. repeat previous steps 10. After clicking Save --> the error message shown is «Child patron cannot be a guarantor.» Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Passing QA - the patches do what they say and the test plan works, however, the patches don't match the bug title. I cannot recreate Caroline's issue though. Two categories marked as 'Can be guarantee' and I am able to assign a relationship between two in the same category, or either way between categories. Can you write a test plan not involving child categories to help recreate Caroline? Created attachment 177840 [details] [review] Bug 38892: Show correct error message when we attempt to add guarantor as a child When we attempt to add child as guarantor the error message shown is 'A guarantor cannot be a guarantee.' it doesn't make sense To recreate: 1. Go to Patrons 2. Click 'New patron' > 'Kid' 3. Fill out surname and cardnumber 4. Under Patron guarantor, click Add guarantor 5. Search for category = Kid and choose one of the patrons 6. Choose the relationship 7. Click 'Save' --> Error A guarantor cannot be a guarantee. 8. Apply the patch 9. repeat previous steps 10. After clicking Save --> the error message shown is «Child patron cannot be a guarantor.» Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed for 25.05! Well done everyone, thank you! Pushed to 24.11.x for 24.11.06 |