Summary: | Longoverdue cron should follow HomeOrHoldingBranch as well as CircControl when using --library flag | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | Command-line Utilities | Assignee: | Andrew Fuerste-Henry <andrew> |
Status: | Pushed to stable --- | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | critical | ||
Priority: | P5 - low | CC: | lucas, martin.renvoize, nick, robin |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
When the longoverdue cron is limited by library, it follows the CircControl system preference. When CircControl is set to "the item's library," this patch allows the HomeOrHoldingBranch system preference to further specify either the item's homebranch or the item's holdingbranch. This makes the longoverdue cron consistent with the application or circulation and fine rules.
|
Version(s) released in: |
25.05.00,24.11.04
|
Circulation function: | |||
Bug Depends on: | 9596 | ||
Bug Blocks: | 38893 | ||
Attachments: |
Bug 38894: Use HomeOrHoldingBranch with longoverdue cronjob
Bug 38894: Use HomeOrHoldingBranch with longoverdue cronjob |
Description
Andrew Fuerste-Henry
2025-01-14 19:21:27 UTC
Created attachment 176534 [details] [review] Bug 38894: Use HomeOrHoldingBranch with longoverdue cronjob To test: 1: have 4 items, 2 with homebranch = Library A and 2 with homebranch = Library B 2: Logged into Library A, check out 1 Library A item and 1 Library B item, both with due dates in the past enough for the longoverdue cron 3: set yourself to Library B, check out 1 Library A item and 1 Library B item, both with due dates in the past enough for the longoverdue cron 4: Run longoverdue cron with --verbose, without --confirm, and without --Library. see that it would act on all 4 items 5: Set CircControl to "the library the item is from" 6: Set HomeOrHoldingBranch to "the item's home library" 7: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 8: See the cron wants to act on the items with homebranch = A 9: Set HomeOrHoldingBranch to "the item's holding library" 10: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 11: See the cron is still trying to act on the two items with homebranch = A 12: Apply patch, restart all 13: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 14: See the cron is now trying to act on the two items with holdingbranch = A 15: Set HomeOrHoldingBranch to "the item's home library" 16: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 17: See the cron wants to act on the items with homebranch = A Created attachment 176888 [details] [review] Bug 38894: Use HomeOrHoldingBranch with longoverdue cronjob To test: 1: Add 4 items, 2 with homebranch = Library A and 2 with homebranch = Library B 2: Logged into Library A, check out 1 Library A item and 1 Library B item, both with due dates in the past enough for the longoverdue cron 3: Set yourself to Library B, check out 1 Library A item and 1 Library B item, both with due dates in the past enough for the longoverdue cron 4: Run longoverdue cron with --verbose, without --confirm, and without --Library. see that it would act on all 4 items 5: Set CircControl to "the library the item is from" 6: Set HomeOrHoldingBranch to "the item's home library" 7: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 8: See the cron wants to act on the items with homebranch = A 9: Set HomeOrHoldingBranch to "the item's holding library" 10: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 11: See the cron is still trying to act on the two items with homebranch = A 12: Apply patch, restart all 13: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 14: See the cron is now trying to act on the two items with holdingbranch = A 15: Set HomeOrHoldingBranch to "the item's home library" 16: Run longoverdue cron with --verbose and --library="A" (where A is the code for your Library A), wihout --confirm 17: See the cron wants to act on the items with homebranch = A Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Quick QA of this one, all working well and scripts are happy. A summary of this change might be helpful! Thanks! Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.04 |