Description
Janusz Kaczmarek
2025-01-18 18:22:30 UTC
Created attachment 180671 [details] [review] Bug 38922: Remove auth_header.origincode, auth_heder.linkid, deletedauth_header.origincode, deletedauth_header.linkid and auth_subfield_structure.linkid from existing installations Created attachment 180672 [details] [review] Bug 38922: Remove auth_header.origincode, auth_heder.linkid, deletedauth_header.origincode, deletedauth_header.linkid and auth_subfield_structure.linkid from new installations Created attachment 180673 [details] [review] Bug 38922: Remove references to auth_header.origincode and auth_heder.linkid from the code Created attachment 180674 [details] [review] Bug 38922: Test data adjustment It seems that the column auth_header.origincode is never used in the code. This column exists from the beginning of auth_header table. BTW, a similar column was present also in marc_biblio in ancient times (e.g. in R_2_2_5), but disappeared in 3.00.00. Same for auth_header.linkid -- the last meaningful use of this column was removed by commit b767f50c in 2007. Test plan: 1. git grep for `origincode` and `linkid` before applying the patch to control that there is no meaningful use of these columns 2. apply the patch ; updatedatabase 3. git grep for `origincode` and `linkid`. Note that 'linkid' in .tt and .js is a completely different linkid. 4. prove t/db_dependent/ImportExportFramework.t Created attachment 180677 [details] [review] Bug 38922: Remove auth_header.origincode, auth_heder.linkid, deletedauth_header.origincode, deletedauth_header.linkid and auth_subfield_structure.linkid from existing installations Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 180678 [details] [review] Bug 38922: Remove auth_header.origincode, auth_heder.linkid, deletedauth_header.origincode, deletedauth_header.linkid and auth_subfield_structure.linkid from new installations Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 180679 [details] [review] Bug 38922: Remove references to auth_header.origincode and auth_heder.linkid from the code Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 180680 [details] [review] Bug 38922: Test data adjustment Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> |