Bug 38957

Summary: EDIFACT messages table should sort by 'Transferred date' descending by default
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: AcquisitionsAssignee: Jake Deery <jake.deery>
Status: Pushed to stable --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: normal    
Priority: P5 - low CC: andrew, jonathan.field, lisette, m.de.rooy, martin.renvoize, paul.derscheid
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
25.05.00,24.11.03
Circulation function:
Bug Depends on: 30070    
Bug Blocks:    
Attachments: Bug 38957: edifactmsgs data table sorts on date
Bug 38957: edifactmsgs data table sorts on date
Bug 38957: edifactmsgs data table sorts on date

Description Nick Clemens (kidclamp) 2025-01-23 14:53:49 UTC
Prior to bug 30070 we showed the most recent edifact messages first:
> order_by => { -desc => 'transfer_date' },

We need to restore this functionality when loading the messages via the api
Comment 1 Jake Deery 2025-02-12 10:59:17 UTC
Created attachment 177841 [details] [review]
Bug 38957: edifactmsgs data table sorts on date

This trivial patch addresses a missing order-by on
the edifact messages datatable since moving to API
based fetching

TO TEST:

a)  Read in a load of EDIFact messages in k.t.d
b)  Notice on the EDIFact messages table the order
    is seemingly arbitrary
c)  APPLY PATCH
d)  Notice the sorting is now by transfer date,
    descending
Comment 2 Lisette Scheer 2025-02-12 17:33:16 UTC
Created attachment 177954 [details] [review]
Bug 38957: edifactmsgs data table sorts on date

Worked as expected

This trivial patch addresses a missing order-by on
the edifact messages datatable since moving to API
based fetching

TO TEST:

a)  Read in a load of EDIFact messages in k.t.d
b)  Notice on the EDIFact messages table the order
    is seemingly arbitrary
c)  APPLY PATCH
d)  Notice the sorting is now by transfer date,
    descending

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
Comment 3 Marcel de Rooy 2025-02-14 08:46:35 UTC
Created attachment 178086 [details] [review]
Bug 38957: edifactmsgs data table sorts on date

This trivial patch addresses a missing order-by on
the edifact messages datatable since moving to API
based fetching

TO TEST:

a)  Read in a load of EDIFact messages in k.t.d
b)  Notice on the EDIFact messages table the order
    is seemingly arbitrary
c)  APPLY PATCH
d)  Notice the sorting is now by transfer date,
    descending

Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2025-02-17 14:07:14 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 5 Paul Derscheid 2025-03-19 23:02:18 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.03