| Summary: | Search history deletion broken in the staff interface | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | Pushed to stable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chughesman, david, m.de.rooy |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes deleting catalog search history in the staff interface (when the EnableSearchHistory system preference is set to 'Keep') - the delete button now works. Previously, selected search terms could not be deleted. (This is related to the DataTables upgrade in Koha 24.11.)
|
Version(s) released in: |
25.05.00,24.11.04
|
| Circulation function: | |||
| Bug Depends on: | 36640 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 38958: Search history deletion broken in the staff interface
Bug 38958: Search history deletion broken in the staff interface Bug 38958: Search history deletion broken in the staff interface |
||
|
Description
Owen Leonard
2025-01-23 16:11:08 UTC
Created attachment 177065 [details] [review] Bug 38958: Search history deletion broken in the staff interface There is some JS on the staff interface search history page which uses a jQuery selector that doesn't seem to work after the DataTables upgrade. This patch fixes it. To test, apply the patch and enable EnableSearchHistory if necessary. - In the staff interface, perform a few catalog searches if necessary. - Choose "Search history" from the user menu in the upper right. - In the table of searches, check the checkbox next to one or more search history entries. - The delete button at the top of the table should become enabled. - Clicking the delete button should work correctly to delete your selected searches. Created attachment 177066 [details] [review] Bug 38958: Search history deletion broken in the staff interface There is some JS on the staff interface search history page which uses a jQuery selector that doesn't seem to work after the DataTables upgrade. This patch fixes it. To test, apply the patch and enable EnableSearchHistory if necessary. - In the staff interface, perform a few catalog searches if necessary. - Choose "Search history" from the user menu in the upper right. - In the table of searches, check the checkbox next to one or more search history entries. - The delete button at the top of the table should become enabled. - Clicking the delete button should work correctly to delete your selected searches. Signed-off-by: David Nind <david@davidnind.com> Created attachment 177102 [details] [review] Bug 38958: Search history deletion broken in the staff interface There is some JS on the staff interface search history page which uses a jQuery selector that doesn't seem to work after the DataTables upgrade. This patch fixes it. To test, apply the patch and enable EnableSearchHistory if necessary. - In the staff interface, perform a few catalog searches if necessary. - Choose "Search history" from the user menu in the upper right. - In the table of searches, check the checkbox next to one or more search history entries. - The delete button at the top of the table should become enabled. - Clicking the delete button should work correctly to delete your selected searches. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 25.05! Well done everyone, thank you! Can this be backported to 24.11.x ? Nice work everyone! Pushed to 24.11.x for 24.11.04 |