Bug 38979

Summary: Standardize word spacing for Cardnumber
Product: Koha Reporter: David Cook <dcook>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: Pushed to main --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: caroline.cyr-la-rose, david, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: String patch Documentation contact:
Documentation submission: Text to go in the release notes:
This changes "cardnumber" to "card number" on the Tools > Patron lists pages.
Version(s) released in:
25.05.00
Circulation function:
Attachments: Bug 38979: Correct instances of "cardnumber" to "card number"
Bug 38979: Correct instances of "cardnumber" to "card number"
Bug 38979: Correct instances of "cardnumber" to "card number"
Bug 38979: Correct instances of "cardnumber" to "card number"
Bug 38979: Correct instances of "cardnumber" to "card number"

Description David Cook 2025-01-27 23:10:56 UTC
A discerning librarian of mine pointed out that the moremember.pl page shows "Card number" and "Borrowernumber". They asked for a space to be added to make the latter "Borrower number", which honestly makes a lot of sense.

While I think that's a good starting point, I figured I'd raise this issue to cover all the different instances for both.

$ grep -R "Card number" koha-tmpl/* | wc -l
36
$ grep -R "Cardnumber" koha-tmpl/* | wc -l
7
$ grep -R "Borrowernumber" koha-tmpl/* | wc -l
11
$ grep -R "Borrower number" koha-tmpl/* | wc -l
1

Chances are that there are more instances with lower cased initial letters, but cardnumber and borrowernumber are valid in links...

It would probably be wise to add a coding guideline for this as well.
Comment 1 Owen Leonard 2025-01-28 18:14:27 UTC
Although it's not on our Terminology page (https://wiki.koha-community.org/wiki/Terminology), we've had discussions about it before.

"cardnumber" as one word is incorrect unless it's referring specifically to a database column.

"borrowernumber" always refers to a database column, and thus has been kept as one word where it is shown to the user. Separating it into "Borrower number" would be confusing because we don't use the word "borrower" in the default American English templates to refer to patrons.

Some of the instances of "borrowernumber" in the staff interface templates are part of operations where the user knows that borrowernumber is a database column because they're doing an import of some kind (tools/modborrowers.t, patron_lists/list.tt).

Originally the patron detail pages did not show the borrowernumber on the assumption that it wasn't relevant, but it was later requested that it be added to the display.
Comment 2 David Cook 2025-01-28 22:42:27 UTC
(In reply to Owen Leonard from comment #1)
> Although it's not on our Terminology page
> (https://wiki.koha-community.org/wiki/Terminology), we've had discussions
> about it before.

In that case, it sounds like "Borrower number" in koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt should become "Borrowernumber"?

And "Cardnumbers" in koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt should become "Card numbers"? I suppose this one is debateable. 

I reckon it might be worth putting into the Terminology in any case.

(In reply to Owen Leonard from comment #1)
> Originally the patron detail pages did not show the borrowernumber on the
> assumption that it wasn't relevant, but it was later requested that it be
> added to the display.

That does sound familiar now that you mention it. One day I'd love to transition from borrowernumber to UUID for security purposes and then it'll get even more interesting...
Comment 3 Owen Leonard 2025-02-10 18:27:35 UTC
Created attachment 177708 [details] [review]
Bug 38979: Correct instances of "cardnumber" to "card number"

The patron list detail page template has several instances of
"cardnumber" which should be corrected to "card number."

To test, apply the patch and go to Tools -> Patron lists.

- Create a patron list if necessary.
- When viewing the patron list, click "Add multiple patrons."
- Under "Choose type of IDs to enter," you should see "Card numbers".
- Add some patrons to the list.
- Try to add one or more of the same patrons to the list using the "Add
  multiple patrons" link..
  - You should see a warning message, "Warning, the following card
    numbers..."
  - The table showing the duplicate card numbers should have the heading
    "Card numbers already in list".
- Use the "Add multiple patrons" link to add card numbers which do not
  exist.
  - You should see a warning message, "Warning, the following card
    numbers..."
  - The table showing the unknown card numbers should have the heading
    "Card numbers not found".

Sponsored-by: Athens County Public Libraries
Comment 4 Owen Leonard 2025-02-12 16:41:23 UTC
Created attachment 177944 [details] [review]
Bug 38979: Correct instances of "cardnumber" to "card number"

The patron list detail page template has several instances of
"cardnumber" which should be corrected to "card number."

To test, apply the patch and go to Tools -> Patron lists.

- Create a patron list if necessary.
- When viewing the patron list, click "Add multiple patrons."
- Under "Choose type of IDs to enter," you should see "Card numbers".
- Add some patrons to the list.
- Try to add one or more of the same patrons to the list using the "Add
  multiple patrons" link..
  - You should see a warning message, "Warning, the following card
    numbers..."
  - The table showing the duplicate card numbers should have the heading
    "Card numbers already in list".
- Use the "Add multiple patrons" link to add card numbers which do not
  exist.
  - You should see a warning message, "Warning, the following card
    numbers..."
  - The table showing the unknown card numbers should have the heading
    "Card numbers not found".

Sponsored-by: Athens County Public Libraries
Comment 5 Owen Leonard 2025-02-12 16:43:11 UTC
Created attachment 177945 [details] [review]
Bug 38979: Correct instances of "cardnumber" to "card number"

The patron list detail page template has several instances of
"cardnumber" which should be corrected to "card number."

To test, apply the patch and go to Tools -> Patron lists.

- Create a patron list if necessary.
- When viewing the patron list, click "Add multiple patrons."
- Under "Choose type of IDs to enter," you should see "Card numbers".
- Add some patrons to the list.
- Try to add one or more of the same patrons to the list using the "Add
  multiple patrons" link..
  - You should see a warning message, "Warning, the following card
    numbers..."
  - The table showing the duplicate card numbers should have the heading
    "Card numbers already in list".
- Use the "Add multiple patrons" link to add card numbers which do not
  exist.
  - You should see a warning message, "Warning, the following card
    numbers..."
  - The table showing the unknown card numbers should have the heading
    "Card numbers not found".

Sponsored-by: Athens County Public Libraries
Comment 6 David Nind 2025-02-14 20:01:11 UTC
Created attachment 178117 [details] [review]
Bug 38979: Correct instances of "cardnumber" to "card number"

The patron list detail page template has several instances of
"cardnumber" which should be corrected to "card number."

To test, apply the patch and go to Tools -> Patron lists.

- Create a patron list if necessary.
- When viewing the patron list, click "Add multiple patrons."
- Under "Choose type of IDs to enter," you should see "Card numbers".
- Add some patrons to the list.
- Try to add one or more of the same patrons to the list using the "Add
  multiple patrons" link..
  - You should see a warning message, "Warning, the following card
    numbers..."
  - The table showing the duplicate card numbers should have the heading
    "Card numbers already in list".
- Use the "Add multiple patrons" link to add card numbers which do not
  exist.
  - You should see a warning message, "Warning, the following card
    numbers..."
  - The table showing the unknown card numbers should have the heading
    "Card numbers not found".

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 7 David Nind 2025-02-14 20:15:16 UTC
I've added to the Terminology page in the wiki as proposed term changes https://wiki.koha-community.org/wiki/Terminology

I've added to the next documentation meeting for approval.
Comment 8 David Nind 2025-02-14 20:17:00 UTC
I notice that for the table (and other tables0, and not related to this bug, that the column label is "Card". 

This seems wrong to me, and I think it should be "Card number".
Comment 9 Marcel de Rooy 2025-02-21 07:59:12 UTC
Created attachment 178447 [details] [review]
Bug 38979: Correct instances of "cardnumber" to "card number"

The patron list detail page template has several instances of
"cardnumber" which should be corrected to "card number."

To test, apply the patch and go to Tools -> Patron lists.

- Create a patron list if necessary.
- When viewing the patron list, click "Add multiple patrons."
- Under "Choose type of IDs to enter," you should see "Card numbers".
- Add some patrons to the list.
- Try to add one or more of the same patrons to the list using the "Add
  multiple patrons" link..
  - You should see a warning message, "Warning, the following card
    numbers..."
  - The table showing the duplicate card numbers should have the heading
    "Card numbers already in list".
- Use the "Add multiple patrons" link to add card numbers which do not
  exist.
  - You should see a warning message, "Warning, the following card
    numbers..."
  - The table showing the unknown card numbers should have the heading
    "Card numbers not found".

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Katrin Fischer 2025-02-21 15:44:51 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 11 Caroline Cyr La Rose 2025-03-25 20:42:57 UTC
This has already been added to the terminology page, and I created a bug to correct the instances in the manual (Bug 39455). Whenever it has gone through all the release maintainers, there is no need to set it to Needs Documenting. You can close it :)