Summary: | Cannot edit default SMTP server config when not using DB | ||
---|---|---|---|
Product: | Koha | Reporter: | David Cook <dcook> |
Component: | Architecture, internals, and plumbing | Assignee: | David Cook <dcook> |
Status: | Pushed to main --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
25.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 38998: Only show Edit link for DB default SMTP server
Bug 38998: Only show Edit link for DB default SMTP server Bug 38998: Only show Edit link for DB default SMTP server |
Description
David Cook
2025-01-30 05:15:43 UTC
Created attachment 177333 [details] [review] Bug 38998: Only show Edit link for DB default SMTP server This change only shows the "Edit" on the smtp_servers.pl page for the "Current default configuratio" if the default configuration can be edited. That is, don't show it when config comes from the code, and do show it when the config comes from the database. Test plan: 0. Apply the patch 1. Go to /cgi-bin/koha/admin/smtp_servers.pl 2. Ensure you delete any SMTP servers you've defined 3. Note that there is no "Edit" button at the bottom of "Current default configuration" 4. Click "New SMTP server" and create a new default server 5. Go to /cgi-bin/koha/admin/smtp_servers.pl 6. Notice how now there is an "Edit" link at the bottom of "Current default configuration" Created attachment 177335 [details] [review] Bug 38998: Only show Edit link for DB default SMTP server This change only shows the "Edit" on the smtp_servers.pl page for the "Current default configuratio" if the default configuration can be edited. That is, don't show it when config comes from the code, and do show it when the config comes from the database. Test plan: 0. Apply the patch 1. Go to /cgi-bin/koha/admin/smtp_servers.pl 2. Ensure you delete any SMTP servers you've defined 3. Note that there is no "Edit" button at the bottom of "Current default configuration" 4. Click "New SMTP server" and create a new default server 5. Go to /cgi-bin/koha/admin/smtp_servers.pl 6. Notice how now there is an "Edit" link at the bottom of "Current default configuration" Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan, works as advertised. Created attachment 177374 [details] [review] Bug 38998: Only show Edit link for DB default SMTP server This change only shows the "Edit" on the smtp_servers.pl page for the "Current default configuratio" if the default configuration can be edited. That is, don't show it when config comes from the code, and do show it when the config comes from the database. Test plan: 0. Apply the patch 1. Go to /cgi-bin/koha/admin/smtp_servers.pl 2. Ensure you delete any SMTP servers you've defined 3. Note that there is no "Edit" button at the bottom of "Current default configuration" 4. Click "New SMTP server" and create a new default server 5. Go to /cgi-bin/koha/admin/smtp_servers.pl 6. Notice how now there is an "Edit" link at the bottom of "Current default configuration" Signed-off-by: Magnus Enger <magnus@libriotech.no> Followed the test plan, works as advertised. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> What means "... when not using DB" in the bug description? Pushed for 25.05! Well done everyone, thank you! |