Summary: | Cannot see suspend column in user's hold table on OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | OPAC | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | Pushed to stable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | alexbuckley, david, gmcharlt, kyle.m.hall, m.de.rooy, paul.derscheid |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the OPAC > Summary > Holds table for a logged in patron - the 'Suspend' column is now shown.
|
Version(s) released in: |
25.05.00,24.11.02
|
Circulation function: | |||
Bug Depends on: | 37972 | ||
Bug Blocks: | |||
Attachments: |
Bug 39003: Move SuspendHoldsOpac check from script to template
Bug 39003: Fix the tab template variable in opac-user.pl Bug 39003: Fix the tab template variable in opac-user.pl Bug 39003: Fix the tab template variable in opac-user.pl Bug 39003: Fix the tab template variable in opac-user.pl |
Description
Lucas Gass (lukeg)
2025-01-30 16:34:35 UTC
I don't see any reason to get the SuspendHoldsOpac value from the script, can check in the template. Created attachment 177357 [details] [review] Bug 39003: Move SuspendHoldsOpac check from script to template To test: 1. SuspendHoldsOpac to 'allow' 2. Make some holds for a patron 3. Log in as that patron and go to 'Summary' 4. Click the 'Holds' tab 5. No suspend column 6. APPLY PATCH, restart_all 7. Try again, the column should show. 8. Turn off SuspendHoldsOpac, the column should be hidden. Created attachment 177359 [details] [review] Bug 39003: Fix the tab template variable in opac-user.pl To test: 1. SuspendHoldsOpac to 'allow' 2. Make some holds for a patron 3. Log in as that patron and go to 'Summary' 4. Click the 'Holds' tab 5. No suspend column 6. APPLY PATCH, restart_all 7. Try again, the column should show. 8. Turn off SuspendHoldsOpac, the column should be hidden. I'm getting the sha1/fake ancestor error. git bz apply 39003 Bug 39003 - Cannot see suspend column in user's hold table on OPAC 177359 - Bug 39003: Fix the tab template variable in opac-user.pl Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 39003: Fix the tab template variable in opac-user.pl error: sha1 information is lacking or useless (opac/opac-user.pl). error: could not build fake ancestor Patch failed at 0001 Bug 39003: Fix the tab template variable in opac-user.pl Created attachment 177366 [details] [review] Bug 39003: Fix the tab template variable in opac-user.pl To test: 1. SuspendHoldsOpac to 'allow' 2. Make some holds for a patron 3. Log in as that patron and go to 'Summary' 4. Click the 'Holds' tab 5. No suspend column 6. APPLY PATCH, restart_all 7. Try again, the column should show. 8. Turn off SuspendHoldsOpac, the column should be hidden. (In reply to David Nind from comment #4) > I'm getting the sha1/fake ancestor error. > > git bz apply 39003 My fault, it should apply now. Created attachment 177367 [details] [review] Bug 39003: Fix the tab template variable in opac-user.pl To test: 1. SuspendHoldsOpac to 'allow' 2. Make some holds for a patron 3. Log in as that patron and go to 'Summary' 4. Click the 'Holds' tab 5. No suspend column 6. APPLY PATCH, restart_all 7. Try again, the column should show. 8. Turn off SuspendHoldsOpac, the column should be hidden. Signed-off-by: David Nind <david@davidnind.com> (In reply to Lucas Gass (lukeg) from comment #6) > (In reply to David Nind from comment #4) > > I'm getting the sha1/fake ancestor error. > > > > git bz apply 39003 > > My fault, it should apply now. Thanks Lucas! Created attachment 177377 [details] [review] Bug 39003: Fix the tab template variable in opac-user.pl To test: 1. SuspendHoldsOpac to 'allow' 2. Make some holds for a patron 3. Log in as that patron and go to 'Summary' 4. Click the 'Holds' tab 5. No suspend column 6. APPLY PATCH, restart_all 7. Try again, the column should show. 8. Turn off SuspendHoldsOpac, the column should be hidden. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 25.05! Well done everyone, thank you! Nice work everyone! Pushed to 24.11.x for 24.11.02 not backporting to 24.05.x unless requested - dependency not in 24.05 |